Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Add warning about old versions #28
Conversation
|
@JulienPalard this looks great to me so far. Are you planning on handling the two remaining items (testing and clever javascript) or are you wanting someone on this end to take it on? |
|
Hi @theacodes If you want to work on the JavaScript, you could see the code of the switchers. Thank you I’ll review this PR |
|
Honestly looking at the way |
|
@theacodes you mean to move the whole red ribbon on the cpython repo? Even its style? |
|
Yeah I think so. The whole version switcher and concept of multiple release
versions is something unique to the cpython docs and isn't shared by other
users of this theme (like packaging.python.org and siblings). Putting it in
cpython will also make it more straightforward to translate with {% trans
%} directives.
I can be convinced otherwise though.
…On Sun, May 12, 2019, 3:18 AM Julien Palard ***@***.***> wrote:
@theacodes <https://github.com/theacodes> you mean to move the whole red
ribbon on the cpython repo? Even its style?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB5I47P7THFJN7KYE5PL6LPU7VH7ANCNFSM4HLTV23A>
.
|
|
I think that's easier in cpython, also because not all versions are using the theme, so I'm moving it there. Thanks @theacodes. |
|
Happy to take a look at the cpython change (even though I'm not a core dev,
I'm extremely familiar with the theme). Just @ me.
…On Tue, May 28, 2019, 7:09 AM Julien Palard ***@***.***> wrote:
I think that's easier in cpython, also because not all versions are using
the theme, so I'm moving it there. Thanks @theacodes
<https://github.com/theacodes>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AAB5I44VIU6CEC5G7H35T3DPXU4KLA5CNFSM4HLTV23KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMH45Y#issuecomment-496533111>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB5I45FO353NX7OBH2M7U3PXU4KLANCNFSM4HLTV23A>
.
|
This is a draft on how we could provide a link to newer versions:
Co-Authored-By: @matrixise
It lacks a few little things:
/instead of linking to a 404.