Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38871: Fix lib2to3 to be able to use in edge cases of filter #17780

Merged
merged 3 commits into from Jan 7, 2020
Merged

bpo-38871: Fix lib2to3 to be able to use in edge cases of filter #17780

merged 3 commits into from Jan 7, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Jan 1, 2020 •
edited

https://bugs.python.org/issue38871
@corona10 corona10 requested review from benjaminp and vstinner Jan 1, 2020
@corona10 corona10 changed the title bpo-38871: Fix lib2to3 to be able to use in edge cases of filter [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
@corona10 corona10 force-pushed the corona10:bpo-38871 branch from 06300d4 to d9e65fd Jan 1, 2020
@corona10 corona10 changed the title [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
@corona10
bpo-38871: Fix lib2to3 to be able to use in edge cases when handling …
Loading status checks…
a602703 
…filter
@corona10 corona10 force-pushed the corona10:bpo-38871 branch from d9e65fd to a602703 Jan 1, 2020
@pablogsal pablogsal self-requested a review Jan 3, 2020
@pablogsal pablogsal self-assigned this Jan 3, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 6, 2020

@benjaminp @pablogsal @isidentical: Would you mind to have a look?
@pablogsal
pablogsal requested changes Jan 6, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-01-18-44-52.bpo-38871.3EEOLg.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 6, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@corona10
bpo-38871: Update NEWS.d
Loading status checks…
75d1792
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member Author

corona10 commented Jan 7, 2020

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 7, 2020

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from pablogsal Jan 7, 2020
@pablogsal
pablogsal reviewed Jan 7, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-01-18-44-52.bpo-38871.3EEOLg.rst Outdated Show resolved Hide resolved
@corona10
bpo-38871: Update NEWS.d
Loading status checks…
4529cb4
@corona10 corona10 requested a review from pablogsal Jan 7, 2020
@pablogsal
pablogsal approved these changes Jan 7, 2020
View changes
@vstinner vstinner merged commit b821173 into python:master Jan 7, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200107.20 succeeded
Details
bedevere/issue-number Issue number 38871 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 7, 2020

Thanks @corona10 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
@corona10 @miss-islington
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
3ce3a3d 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 7, 2020

GH-17899 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
@corona10 @miss-islington
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
d6a9419 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 7, 2020

Thanks @corona10 for updating the NEWS entry. I rewrote the commit message.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 7, 2020

GH-17900 is a backport of this pull request to the 3.7 branch.
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Jan 7, 2020

Thanks for the PR, @corona10 !
miss-islington added a commit that referenced this pull request Jan 7, 2020
@miss-islington @corona10
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
535a3c4 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jan 7, 2020
@miss-islington @corona10
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
39a5c88 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@vstinner vstinner

@benjaminp benjaminp

Assignees

@pablogsal pablogsal

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@corona10 @vstinner @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.