Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some classes. (GH-14952) #17836

Open
wants to merge 1 commit into
base: 3.8
from
Open

[3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some classes. (GH-14952) #17836

wants to merge 1 commit into from
+1,292 −1,147

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 5, 2020 •
edited by bedevere-bot

They now return NotImplemented for unsupported type of the other operand.
(cherry picked from commit 662db12)

https://bugs.python.org/issue37685
@serhiy-storchaka
[3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some cla…
Loading status checks…
176a341 
…sses. (GH-14952)

They now return NotImplemented for unsupported type of the other operand..
(cherry picked from commit 662db12)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka requested a review from ambv Jan 5, 2020
@serhiy-storchaka serhiy-storchaka requested review from 1st1, asvetlov and python/email-team as code owners Jan 5, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jan 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/email-team email-team

@ambv ambv

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
CLA signed awaiting core review type-bugfix
Projects
None yet
Milestone
No milestone
3 participants
@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.