Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39200: Correct the error message for min/max builtin function #17814
Conversation
This comment has been minimized.
This comment has been minimized.
|
Seems like a duplicate of #17813 |
This comment has been minimized.
This comment has been minimized.
|
Sorry, misread the diff and PR linked to issue as duplicate solution. |
This comment has been minimized.
This comment has been minimized.
Yes, IMHO, The issue title should be updated as I wrote at the bpo-39200 |
This comment has been minimized.
This comment has been minimized.
|
Let's hold until we decide how to go in #17813 |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
@pablogsal Updated :) |
vstinner
merged commit abdc634
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 10, 2020
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 10, 2020
…thonGH-17814) Correct the error message when calling the min() or max() with no arguments. (cherry picked from commit abdc634) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 10, 2020
|
GH-17941 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 10, 2020
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 10, 2020
…thonGH-17814) Correct the error message when calling the min() or max() with no arguments. (cherry picked from commit abdc634) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 10, 2020
|
GH-17943 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
corona10 commentedJan 3, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39200