Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore #16509

Merged
merged 2 commits into from Oct 1, 2019
Merged

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore #16509

merged 2 commits into from Oct 1, 2019

Conversation

@vstinner
Copy link
Member

vstinner commented Oct 1, 2019 •
edited by bedevere-bot

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.

https://bugs.python.org/issue38304
@vstinner
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore
Loading status checks…
20fb112 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
@vstinner vstinner requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan, warsaw and python/windows-team as code owners Oct 1, 2019
@vstinner
Update header files
Loading status checks…
fc5e20f
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Oct 1, 2019

I forgot to update PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() in my PR #16500. There is no more need to return PyStatus since these functions cannot fail anymore. They don't allocate any memory: strings are initialized to NULL, lists to empty lists (which doesn't allocate any memory).
@vstinner vstinner mentioned this pull request Oct 1, 2019
Merged
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Oct 1, 2019

cc @ncoghlan @ambv That can wait for 3.8.0rc2 or 3.8.0 final if it's too late for rc1.
@ambv
ambv approved these changes Oct 1, 2019
View changes
Copy link
Contributor

ambv left a comment

Wait for CI and merge.
@vstinner vstinner merged commit 8462a49 into python:master Oct 1, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191001.9 succeeded
Details
bedevere/issue-number Issue number 38304 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner vstinner deleted the vstinner:pyconfig_init branch Oct 1, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 1, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 1, 2019

GH-16510 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Oct 1, 2019
@miss-islington @vstinner
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d49f096 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
(cherry picked from commit 8462a49)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@ncoghlan

This comment has been minimized.

Sign in to view
Copy link
Contributor

ncoghlan commented Oct 1, 2019

Good catch!
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner @jacobneiltaylor
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (pythonGH-…
23b6e22 
…16509)

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

@python/windows-team windows-team

@brettcannon brettcannon

@warsaw warsaw

@encukou encukou

@ncoghlan ncoghlan

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@vstinner @miss-islington @bedevere-bot @ncoghlan @ambv @the-knights-who-say-ni
You can’t perform that action at this time.