Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upclinic: Fix clinic anti-pattern #17852
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 6, 2020
|
Thanks @corona10 for the PR, and @pablogsal for merging it |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2020
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2020
This comment has been minimized.
This comment has been minimized.
|
Normally, we don't accept this kind of refactorings to not mess too much with the blame, but the fix is simple enough so I will merge. Note: we cannot risk backports to 3.8 and 3.7 branches as this is not a bugfix. Please, take into account in the future when adding the 'needs backport' labels. |
sthagen
added a commit
to sthagen/cpython
that referenced
this pull request
Jan 6, 2020
argument-clinic: Simplify multi-line string handling (pythonGH-17852)
gousaiyang
added a commit
to gousaiyang/cpython
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
corona10 commentedJan 6, 2020
•
edited
https://bugs.python.org/msg359368