Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific about the `.so` gitignore patterns #17328

Merged
merged 1 commit into from Nov 27, 2019
Merged

Be more specific about the `.so` gitignore patterns #17328

merged 1 commit into from Nov 27, 2019

Conversation

@asottile
Copy link
Contributor

asottile commented Nov 21, 2019

In #15823 the pattern was changed from libpython*.so* to *.so* which
matches a bit too greedily for some packagers. For instance this trips up
debian/README.source. A more specific pattern fixes this issue.
@asottile
Be more specific about the `.so` gitignore patterns
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52531d5 
In #15823 the pattern was changed from `libpython*.so*` to `*.so*` which
matches a bit too greedily for some packagers.  For instance this trips up
`debian/README.source`.  A more specific pattern fixes this issue.
@asottile

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

asottile commented Nov 21, 2019

CC @zware @gnprice
@eamanu
eamanu suggested changes Nov 23, 2019
View changes
Copy link
Contributor

eamanu left a comment •
edited

I don't know if separate the entry on .gitignore is a good idea.

*.so* work fine for *.so* files
@asottile

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

asottile commented Nov 23, 2019

I don't know if separate the entry on .gitignore is a good idea.

*.so* work fine for *.so* files

@eamanu please see the linked discussion -- thanks!
@zware
zware approved these changes Nov 27, 2019
View changes
@zware zware merged commit 1ef4c32 into python:master Nov 27, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191121.53 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 27, 2019

Thanks @asottile for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 27, 2019

Sorry @asottile and @zware, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1ef4c32c8d4f374adfea599f033fa61254bf951d 3.8
@asottile asottile deleted the asottile:patch-1 branch Nov 27, 2019
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@asottile @jacobneiltaylor
Be more specific about the `.so` gitignore patterns (pythonGH-17328)
be2aefb 
In pythonGH-15823 the pattern was changed from `libpython*.so*` to `*.so*` which
matches a bit too greedily for some packagers.  For instance this trips up
`debian/README.source`.  A more specific pattern fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu

@zware zware

Assignees

@zware zware

Labels
CLA signed needs backport to 3.8 skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@asottile @miss-islington @zware @eamanu @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.