bpo-22640: Add silent mode to py_compile #12976

nanjekyejoannah · 2019-04-26T22:11:42Z

I have added silent mode to py_compile.

https://bugs.python.org/issue22640

berkerpeksag

Please wait for @brettcannon's feedback before addressing my review comments. I opened bpo-22640 years ago and unfortunately I forgot to add Brett to nosy list.

Lib/py_compile.py

Lib/test/test_py_compile.py

berkerpeksag · 2019-04-26T23:12:09Z

Lib/test/test_py_compile.py

@@ -192,6 +192,14 @@ def test_invalidation_mode(self):
                fp.read(), 'test', {})
        self.assertEqual(flags, 0b1)

+    def test_quiet(self):
+        bad_coding = os.path.join(os.path.dirname(__file__), 'bad_coding2.py')
+        with support.captured_stderr():


Suggested change

with support.captured_stderr():

with support.captured_stderr() as stderr:

Then we can add something like

self.assertEqual(stderr.getvalue(), '')

to test the quiet option.

Why did you mark this resolved? It still needs to be addressed.

Sorry, I had confused it with @vadmium 's comment .

berkerpeksag · 2019-04-26T23:12:09Z

Misc/NEWS.d/next/Library/2019-04-26-22-13-26.bpo-22640.p3rheW.rst

@@ -0,0 +1 @@
+`py_compile` now supports silent mode.


:func:`py_compile.compile`

And please add "Patch by Your Name.".

This comment is still needs to be addressed as well.

Doc/whatsnew/3.8.rst

Doc/library/py_compile.rst

bedevere-bot · 2019-04-26T23:12:13Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ZackerySpytz

Do not use "quite" instead of "quiet", please.

Doc/library/py_compile.rst

Lib/py_compile.py

Lib/test/test_py_compile.py

Doc/library/py_compile.rst

Doc/whatsnew/3.8.rst

nanjekyejoannah · 2019-04-27T21:38:38Z

Please wait for @brettcannon's feedback before addressing my review comments. I opened bpo-22640 years ago and unfortunately I forgot to add Brett to nosy list.

Noted.

brettcannon · 2019-05-06T18:53:54Z

I'm fine with the idea.

nanjekyejoannah · 2019-05-08T14:40:32Z

Great, I will finish addressing the reviews on this PR as soon as I can.

nanjekyejoannah · 2019-05-10T15:12:02Z

I have made the requested changes; please review again.

bedevere-bot · 2019-05-10T15:12:06Z

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag

This looks good to me, thank you! I just left mostly trivial comments.

You may also want to check documentation changes with a native English speaker. I'm not a native speaker, so they may help us to simply documentation changes :)

Doc/library/py_compile.rst

Doc/whatsnew/3.8.rst

Lib/py_compile.py

bedevere-bot · 2019-05-15T17:38:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

… into issue22640

Doc/whatsnew/3.8.rst

ZackerySpytz · 2019-05-27T18:13:54Z

@nanjekyejoannah It seems that you marked my comment as "resolved", but the "What's New" entry still falsely states that py_compile.compile is a method. Please fix that.

nanjekyejoannah · 2019-05-27T18:37:31Z

@berkerpeksag PTAL .

nanjekyejoannah · 2019-05-28T15:00:13Z

I have made the requested changes; please review again .

bedevere-bot · 2019-05-28T15:00:21Z

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag · 2019-05-28T16:29:13Z

Thanks!

vstinner · 2019-06-04T12:48:56Z

Well done @nanjekyejoannah!

merwok · 2019-11-15T00:01:54Z

Follow-up in #17134 to fix the NameErrors in main.
As this is already released, 3.7 should get a simple fix and 3.8 the missing part of the feature 🙂

vstinner · 2020-04-30T22:26:12Z

It seems like this change introduced a regression in main(): see https://bugs.python.org/issue40456

merwok · 2020-04-30T22:27:16Z

It seems that you missed my previous message Victor! 🙂

vstinner · 2020-04-30T22:53:42Z

It seems that you missed my previous message Victor! slightly_smiling_face

Oh, right. Well, the main() changes of this PR should be reverted in 3.8. #17134 is new feature which should not into 3.8.

the-knights-who-say-ni added the CLA signed label Apr 26, 2019

bedevere-bot added the awaiting review label Apr 26, 2019

nanjekyejoannah changed the title ~~bpo-22640: Add silent mode for py_compile~~ bpo-22640: Add silent mode to py_compile Apr 26, 2019

berkerpeksag requested changes Apr 26, 2019

View changes

bedevere-bot removed the awaiting review label Apr 26, 2019

bedevere-bot added the awaiting changes label Apr 26, 2019

berkerpeksag requested a review from brettcannon Apr 26, 2019

ZackerySpytz reviewed Apr 27, 2019

View changes

Doc/library/py_compile.rst Outdated Show resolved Hide resolved

Doc/library/py_compile.rst Outdated Show resolved Hide resolved

tirkarthi reviewed Apr 27, 2019

View changes

Lib/py_compile.py Outdated Show resolved Hide resolved

Lib/py_compile.py Outdated Show resolved Hide resolved

vadmium reviewed Apr 27, 2019

View changes

Lib/py_compile.py Outdated Show resolved Hide resolved

Lib/test/test_py_compile.py Show resolved Hide resolved

Doc/library/py_compile.rst Outdated Show resolved Hide resolved

Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved

nanjekyejoannah force-pushed the issue22640 branch from 44d5270 to 754afeb Compare May 10, 2019

bedevere-bot added awaiting change review and removed awaiting changes labels May 10, 2019

berkerpeksag requested changes May 15, 2019

View changes

bedevere-bot added awaiting changes and removed awaiting change review labels May 15, 2019

nanjekyejoannah requested review from 1st1, asvetlov, encukou, ericsnowcurrently, gpshead, gvanrossum and ilevkivskyi as code owners May 17, 2019

nanjekyejoannah and others added 6 commits May 26, 2019

Add silent mode to py_compile

1661b79

Fix Doc

398ce63

Fix Docs

b1d6fb2

Fix Docs

ee76f31

Merge branch 'issue22640' of https://github.com/nanjekyejoannah/cpython…

696fcca

… into issue22640

Fix Docs

c51cd67

ZackerySpytz reviewed May 27, 2019

View changes

Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved

change to func

65afe83

nanjekyejoannah added 2 commits May 27, 2019

Remove function.

4c55240

Correct grammar

07139d6

bedevere-bot added awaiting change review and removed awaiting changes labels May 28, 2019

berkerpeksag approved these changes May 28, 2019

View changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 28, 2019

berkerpeksag merged commit 2e33ecd into python:master May 28, 2019
5 checks passed

bedevere-bot removed the awaiting merge label May 28, 2019

nanjekyejoannah deleted the issue22640 branch May 29, 2019

merwok mentioned this pull request Dec 3, 2019

bpo-38731: Add --quiet option to py_compile CLI #17134

Merged

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-22640: Add silent mode to py_compile.compile() (pythonGH-12976)

3db9ade

bpo-22640: Add silent mode to py_compile #12976

bpo-22640: Add silent mode to py_compile #12976

nanjekyejoannah commented Apr 26, 2019 •

edited by bedevere-bot

berkerpeksag left a comment

berkerpeksag Apr 26, 2019

berkerpeksag May 24, 2019

nanjekyejoannah May 24, 2019

berkerpeksag Apr 26, 2019

berkerpeksag Apr 26, 2019

berkerpeksag May 24, 2019

bedevere-bot commented Apr 26, 2019

ZackerySpytz left a comment

nanjekyejoannah commented Apr 27, 2019 •

edited by bedevere-bot

brettcannon commented May 6, 2019

nanjekyejoannah commented May 8, 2019 •

edited

nanjekyejoannah commented May 10, 2019

bedevere-bot commented May 10, 2019

berkerpeksag left a comment

bedevere-bot commented May 15, 2019

ZackerySpytz commented May 27, 2019

nanjekyejoannah commented May 27, 2019

nanjekyejoannah commented May 28, 2019

bedevere-bot commented May 28, 2019

berkerpeksag commented May 28, 2019

vstinner commented Jun 4, 2019

merwok commented Nov 15, 2019

vstinner commented Apr 30, 2020

merwok commented Apr 30, 2020

vstinner commented Apr 30, 2020

	with support.captured_stderr():
	with support.captured_stderr() as stderr:

bpo-22640: Add silent mode to py_compile #12976

bpo-22640: Add silent mode to py_compile #12976

Conversation

nanjekyejoannah commented Apr 26, 2019 • edited by bedevere-bot

berkerpeksag left a comment

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

berkerpeksag May 24, 2019

Choose a reason for hiding this comment

nanjekyejoannah May 24, 2019

Choose a reason for hiding this comment

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

berkerpeksag May 24, 2019

Choose a reason for hiding this comment

bedevere-bot commented Apr 26, 2019

ZackerySpytz left a comment

nanjekyejoannah commented Apr 27, 2019 • edited by bedevere-bot

brettcannon commented May 6, 2019

nanjekyejoannah commented May 8, 2019 • edited

nanjekyejoannah commented May 10, 2019

bedevere-bot commented May 10, 2019

berkerpeksag left a comment

bedevere-bot commented May 15, 2019

ZackerySpytz commented May 27, 2019

nanjekyejoannah commented May 27, 2019

nanjekyejoannah commented May 28, 2019

bedevere-bot commented May 28, 2019

berkerpeksag commented May 28, 2019

vstinner commented Jun 4, 2019

merwok commented Nov 15, 2019

vstinner commented Apr 30, 2020

merwok commented Apr 30, 2020

vstinner commented Apr 30, 2020

nanjekyejoannah commented Apr 26, 2019 •

edited by bedevere-bot

nanjekyejoannah commented Apr 27, 2019 •

edited by bedevere-bot

nanjekyejoannah commented May 8, 2019 •

edited