Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38341: Add SMTPNotSupportedError in the exports of smtplib #16525

Merged
merged 3 commits into from Oct 5, 2019
Merged

bpo-38341: Add SMTPNotSupportedError in the exports of smtplib #16525

merged 3 commits into from Oct 5, 2019

Conversation

rockwelln
Copy link
Contributor

@rockwelln rockwelln commented Oct 1, 2019 •
edited by bedevere-bot

Pretty simple add in the all variable, the missing exception SMTPNotSupportedError

https://bugs.python.org/issue38341

@rockwelln rockwelln requested a review from a team as a code owner Oct 1, 2019
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 1, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rockwelln

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

brandtbucher commented Oct 1, 2019 •
edited

Thanks for your time @rockwelln, and welcome to CPython! 😎

brandtbucher
brandtbucher requested changes Oct 1, 2019
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment •
edited

This looks like a good change. Can you also create a NEWS entry, since this changes smtplib's exported names?

Just something simple, like:

Added :exc:`smtplib.SMTPNotSupportedError` to ``__all__`` in :mod:`smtplib`.

@rockwelln
Copy link
Contributor Author

rockwelln commented Oct 1, 2019

Thank you @brandtbucher :-), I posted the news.
Don't hesitate if I missed something, it's the first time I propose a change in CPython.

@rockwelln @brandtbucher
Update Misc/NEWS.d/next/Library/2019-10-01-21-06-18.bpo-38341.uqwgU_.rst
a7921e6 
of course! thank you for the suggestion, I missed it in the conversation.

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@brandtbucher
Copy link
Member

brandtbucher commented Oct 1, 2019

Awesome. I assume you’ve seen the bot’s message about the CLA?

@rockwelln
Copy link
Contributor Author

rockwelln commented Oct 1, 2019

thanks!
about the CLA, I signed it few minutes ago, it should be ok now.

maxking
maxking approved these changes Oct 5, 2019
View changes
Copy link
Contributor

@maxking maxking left a comment

Thanks for working on this @rockwelln

Since this is a public API (https://docs.python.org/3/library/smtplib.html?highlight=smtplib#smtplib.SMTPNotSupportedError) it should be exported.

@maxking maxking merged commit 3faf826 into python:master Oct 5, 2019
@bedevere-bot
Copy link

bedevere-bot commented Oct 5, 2019

@maxking: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2019

Thanks @rockwelln for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2019

Sorry @rockwelln and @maxking, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3faf826e5879536d2272f1a51c58965a16827f81 3.8

@bedevere-bot
Copy link

bedevere-bot commented Oct 5, 2019

GH-16590 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2019
@rockwelln @miss-islington
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (pytho…
98082c1 
…nGH-16525)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 3faf826)

Co-authored-by: nde <denayer.norman@gmail.com>
@brandtbucher
Copy link
Member

brandtbucher commented Oct 5, 2019

Congrats on your first CPython contribution @rockwelln! 🍾

Looking forward to seeing more from you in the future.

@rockwelln
Copy link
Contributor Author

rockwelln commented Oct 6, 2019

thank you very much @brandtbucher for your support. this first experience was a pleasure.
I'd be happy to contribute again.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2019

Thanks @rockwelln for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2019

GH-16721 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2019
@rockwelln @miss-islington
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (pytho…
f4b0df8 
…nGH-16525)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 3faf826)

Co-authored-by: nde <denayer.norman@gmail.com>
@ned-deily
Copy link
Member

ned-deily commented Oct 11, 2019

(The 3.8 autobackport failed for some reason originally, manually restarted it.)

miss-islington added a commit that referenced this pull request Oct 12, 2019
@miss-islington @rockwelln
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525
1da648a 
)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 3faf826)

Co-authored-by: nde <denayer.norman@gmail.com>
miss-islington added a commit that referenced this pull request Oct 12, 2019
@miss-islington @rockwelln
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525
cb580d6 
)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 3faf826)

Co-authored-by: nde <denayer.norman@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@rockwelln @brandtbucher
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (pytho…
e4240e3 
…n#16525)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxking maxking

@brandtbucher brandtbucher

Assignees

@maxking maxking

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rockwelln @the-knights-who-say-ni @brandtbucher @bedevere-bot @miss-islington @ned-deily @maxking