Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38708: email: Fix a potential IndexError when parsing Message-ID #17504
Conversation
Fix a potential IndexError when passing an empty value to the message-id parser. Instead, HeaderParseError should be raised.
Looks good to me |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 9, 2019
Thanks @maxking for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2019
…ythonGH-17504) Fix a potential IndexError when passing an empty value to the message-id parser. Instead, HeaderParseError should be raised. (cherry picked from commit 3ae4ea1) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 9, 2019
GH-17515 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
maxking commentedDec 8, 2019
•
edited by bedevere-bot
Fix a potential IndexError when passing an empty value to the message-id
parser. Instead, HeaderParseError should be raised.
https://bugs.python.org/issue38708