Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39152: add missing ttk.Scale.configure return value #17815
Conversation
tkinter.ttk.Scale().configure() now returns a configuration. Change posted by Giovanni Lombardo.
Please add a test. |
This comment has been minimized.
This comment has been minimized.
Actually it would be enough to remove special cases for |
This comment has been minimized.
This comment has been minimized.
tkinter.test.widget.AbstractWidgetTest has two tests skip for Scale. I removed the skip in test_keys that works with this patch. The skipped part of test_param,
still fails after the patch, 9 times, at the configure call because the override tries to update kw with a string.
The solution is to not do this. I will submit a further commit that fixes this and removes the 2nd skip. |
Don't update dict with None or string. Remove skip of param test that now works. update blurb.
This comment has been minimized.
This comment has been minimized.
Scale.configure now returns the value returned by Widget.configure called with unaltered arguments. If tests pass, as they did on my machine, I think this is ready to merge. The additional override code only involves tkinter's addition of '<>' events. Since Scale is not currently included in the ttk doc, the docstring is the only mention of the addition. (Since the notification results from action by the program getting the notice (rather than by a user), I am not sure why it is useful.) |
5ea7bb2
into
python:master
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
Thanks @terryjreedy for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
Sorry @terryjreedy, I had trouble checking out the |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 5, 2020
GH-17839 is a backport of this pull request to the 3.7 branch. |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
Thanks @terryjreedy for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
I'm having trouble backporting to |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
Thanks @terryjreedy for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 5, 2020
GH-17840 is a backport of this pull request to the 3.8 branch. |
tkinter.ttk.Scale().configure([name]) now returns a configuration tuple for name or a list thereof for all options. Based on patch Giovanni Lombardo.
terryjreedy commentedJan 3, 2020
•
edited
tkinter.ttk.Scale().configure([name]) now returns a configuration tuple for name
or a list thereof for all options. Based on patch Giovanni Lombardo.
https://bugs.python.org/issue39152