Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31522: mailbox: pass from_ parameter to get_bytes #9857

Merged
merged 2 commits into from Oct 19, 2018
Merged

bpo-31522: mailbox: pass from_ parameter to get_bytes #9857

merged 2 commits into from Oct 19, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Oct 13, 2018 •
edited by bedevere-bot

Added tests that failed before the change and pass after the change.

https://bugs.python.org/issue31522

@csabella csabella requested a review from a team as a code owner Oct 13, 2018
bitdancer
bitdancer requested changes Oct 16, 2018
View changes
Misc/NEWS.d/next/Library/2018-10-13-18-16-20.bpo-31522.rWBb43.rst Outdated
@@ -0,0 +1 @@
In `mailbox._mboxMMDF.get_string`, pass *from_* parameter to ``get_bytes``.
Copy link
Member

@bitdancer bitdancer Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes what was done, but the changelog should in general describe the externally visible affects of the change. In this case, I would write "The mailbox mbox get_string function from_ parameter can now successfully be set to a non-default value".

Copy link
Contributor Author

@csabella csabella Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! :-)

@bedevere-bot
Copy link

bedevere-bot commented Oct 16, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor Author

csabella commented Oct 16, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Oct 16, 2018

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bitdancer bitdancer merged commit d16f012 into python:master Oct 19, 2018
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2018

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

@csabella csabella deleted the bpo31522 branch Oct 19, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@csabella @yahya-abou-imran
bpo-31522: mailbox.get_string: pass from_ parameter to get_bytes (p…
82764ac 
…ython#9857)

This allows *from_* to be successfully set to a non-default value when calling mbox.get_string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdancer bitdancer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csabella @bedevere-bot @bitdancer @the-knights-who-say-ni