Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39242: Updated the Gmane domain into news.gmane.io #17903

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Jan 8, 2020

@@ -0,0 +1,2 @@
Updated the Gmane domain which is used for the :class:`~nntplib.NNTP`'s example
news reader server

This comment has been minimized.

Copy link
@vstinner

vstinner Jan 8, 2020

Member

Maybe mention the old and new domain. Please also add a final dot to the sentence. You may also mention that nntplib tests are also updated.

@corona10

This comment has been minimized.

Copy link
Member Author

corona10 commented Jan 8, 2020

Doc/whatsnew/3.3.rst:1565 is skipped since 3.3 is end-of-life.

@corona10 corona10 requested a review from vstinner Jan 8, 2020
@vstinner vstinner merged commit 2e6a8ef into python:master Jan 8, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200108.14 succeeded
Details
bedevere/issue-number Issue number 39242 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Jan 8, 2020

Thanks @corona10 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 8, 2020
(cherry picked from commit 2e6a8ef)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 8, 2020

GH-17904 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 8, 2020
(cherry picked from commit 2e6a8ef)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 8, 2020

GH-17905 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 8, 2020
(cherry picked from commit 2e6a8ef)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jan 8, 2020
(cherry picked from commit 2e6a8ef)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 8, 2020
bpo-39242: Updated the Gmane domain into news.gmane.io (pythonGH-17903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.