Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in formatter_unicode #16831

Merged
merged 1 commit into from Oct 25, 2019
Merged

Conversation

hansrajdas
Copy link
Contributor

@hansrajdas hansrajdas commented Oct 17, 2019

numbers's -> number's

Automerge-Triggered-By: @Mariatta

eamanu
eamanu approved these changes Oct 17, 2019
Copy link
Contributor

@eamanu eamanu left a comment

Good catch.

@Mariatta Mariatta changed the title Typo fix: numbers's should be number's Fix typo in formatter_unicode Oct 25, 2019
@Mariatta Mariatta added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Oct 25, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2019

@hansrajdas: Status check is done, and it's a success .

@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 7320ec0 into python:master Oct 25, 2019
@Mariatta
Copy link
Sponsor Member

Mariatta commented Oct 25, 2019

Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2019

Thanks @hansrajdas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2019

GH-16922 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2019

GH-16923 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2019
numbers's -> number's
(cherry picked from commit 7320ec0)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2019
numbers's -> number's
(cherry picked from commit 7320ec0)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2019
numbers's -> number's
(cherry picked from commit 7320ec0)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants