Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38535: Fix positions for AST nodes for calls without arguments in decorators. #16861

Merged
merged 1 commit into from Oct 26, 2019
Merged

bpo-38535: Fix positions for AST nodes for calls without arguments in decorators. #16861

merged 1 commit into from Oct 26, 2019
+12 −8

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 20, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue38535
@serhiy-storchaka
bpo-38535: Fix positions for AST nodes for calls without arguments in…
Loading status checks…
d84d0b4 
… decorators.
@asottile

This comment has been minimized.

Sign in to view
Copy link
Contributor

asottile commented Oct 25, 2019

should this be backported? often changes in col_offset / lineno can cause some annoying breaks in cpython patch versions for linters and such
@ilevkivskyi
ilevkivskyi approved these changes Oct 25, 2019
View changes
Copy link
Contributor

ilevkivskyi left a comment

Thanks!
@serhiy-storchaka serhiy-storchaka merged commit 26ae9f6 into python:master Oct 26, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191025.9 succeeded
Details
bedevere/issue-number Issue number 38535 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@serhiy-storchaka serhiy-storchaka deleted the serhiy-storchaka:ast-decorator-call-without-args branch Oct 26, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 26, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 26, 2019

GH-16929 is a backport of this pull request to the 3.8 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 26, 2019

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 26ae9f6d3d755734c9f371b9356325afe5764813 3.7
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 26, 2019

Sorry @serhiy-storchaka, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 26ae9f6d3d755734c9f371b9356325afe5764813 2.7
miss-islington added a commit that referenced this pull request Oct 26, 2019
@miss-islington @serhiy-storchaka
bpo-38535: Fix positions for AST nodes for calls without arguments in…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba3a566 
… decorators. (GH-16861)

(cherry picked from commit 26ae9f6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 26, 2019

GH-16930 is a backport of this pull request to the 3.7 branch.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 26, 2019
@serhiy-storchaka
[3.7] bpo-38535: Fix positions for AST nodes for calls without argume…
5b48148 
…nts in decorators. (pythonGH-16861).

(cherry picked from commit 26ae9f6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 26, 2019
@serhiy-storchaka
[2.7] bpo-38535: Fix positions for AST nodes for calls without argume…
1cb4e46 
…nts in decorators. (pythonGH-16861).

(cherry picked from commit 26ae9f6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 26, 2019

GH-16931 is a backport of this pull request to the 2.7 branch.
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 26, 2019
serhiy-storchaka added a commit that referenced this pull request Oct 26, 2019
@serhiy-storchaka
[3.7] bpo-38535: Fix positions for AST nodes for calls without argume…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91fc9cf 
…nts in decorators. (GH-16861). (GH-16930)

(cherry picked from commit 26ae9f6)
serhiy-storchaka added a commit that referenced this pull request Oct 26, 2019
@serhiy-storchaka
[2.7] bpo-38535: Fix positions for AST nodes for calls without argume…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
493fef6 
…nts in decorators. (GH-16861). (GH-16931)

(cherry picked from commit 26ae9f6)
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@serhiy-storchaka @jacobneiltaylor
bpo-38535: Fix positions for AST nodes for calls without arguments in…
ee2076f 
… decorators. (pythonGH-16861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@serhiy-storchaka @asottile @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni
You can’t perform that action at this time.