Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing acknowledgement #17130

Merged
merged 1 commit into from Nov 13, 2019
Merged

Adding missing acknowledgement #17130

merged 1 commit into from Nov 13, 2019

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Nov 12, 2019 •
edited by bedevere-bot

Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)

@Kentzo
Missing ack
387ffc7 
bpo-26467: large chunk of the "based on" code
bpo-29302
@brandtbucher brandtbucher added skip issue skip news docs labels Nov 12, 2019
brandtbucher
brandtbucher approved these changes Nov 12, 2019
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Thanks for your help!

@benjaminp benjaminp merged commit d6d6e2a into python:master Nov 13, 2019
4 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 13, 2019

Thanks @Kentzo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 13, 2019

GH-17138 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this issue Nov 13, 2019
@miss-islington @Kentzo
Add Ilya Kulakov to Misc/ACKS. (GH-17130)
e5125f7 
Contributions on bpo-26467 and bpo-29302.
(cherry picked from commit d6d6e2a)

Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com>
jacksonriley pushed a commit to jacksonriley/cpython that referenced this issue Nov 18, 2019
@Kentzo @jacksonriley
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
c84b8f2 
Contributions on bpo-26467 and bpo-29302.
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this issue Dec 5, 2019
@Kentzo @jacobneiltaylor
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
9844b12 
Contributions on bpo-26467 and bpo-29302.
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Jan 31, 2020
@Kentzo @shihai1991
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
39c406a 
Contributions on bpo-26467 and bpo-29302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
CLA signed docs skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Kentzo @miss-islington @bedevere-bot @brandtbucher @benjaminp @the-knights-who-say-ni