bpo-38567: Handle bytes as input to urllib.parse.unquote_plus #16903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test non-ascii input as bytes.
eamanu
suggested changes
Oct 24, 2019
| @@ -734,6 +734,10 @@ def unquote_plus(string, encoding='utf-8', errors='replace'): | |||
|
|
|||
| unquote_plus('%7e/abc+def') -> '~/abc def' | |||
| """ | |||
| if isinstance(string, bytes): | |||
There was a problem hiding this comment.
according to the documentation https://docs.python.org/3/library/urllib.parse.html?highlight=urllib#urllib.parse.unquote_plus string must be a str type.
If you need parse bytes you must use unquote_to_bytes. IMO here you need prove if
string is a str
if !isinstance(string, str):
raise TypeError ('a str object is required')
There was a problem hiding this comment.
I think handling both bytes and str would make it more like unquote in 3.9 (https://docs.python.org/3.9/library/urllib.parse.html?highlight=urllib#urllib.parse.unquote).
I would expect them to behave the same and accept the same types.
|
I hope the comments I made to the proposed changes could be reviewed. The changes would make the urllib.parse API more consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Handle bytes as input to unquote_plus
https://bugs.python.org/issue38567