Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39166: Fix trace of last iteration of async for loops #17800

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39166: Fix trace of last iteration of async for loops #17800

wants to merge 1 commit into from
+87 −5

Conversation

@pablogsal
Copy link
Member

pablogsal commented Jan 2, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39166
@pablogsal pablogsal requested a review from markshannon Jan 2, 2020
@pablogsal pablogsal self-assigned this Jan 2, 2020
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member Author

pablogsal commented Jan 2, 2020 •
edited

@markshannon Could you take a look at this when you have time? I am not happy about this solution as is just adding more shrinkwrap but solving the general case is not immediate. Do you have a better idea for now?

@nedbat Could you check if this breaks anything else in your test suite?
@pablogsal pablogsal force-pushed the pablogsal:bpo-39166 branch from 98a721d to eadf971 Jan 2, 2020
@nedbat

This comment has been minimized.

Sign in to view
Copy link
Member

nedbat commented Jan 2, 2020

All my tests pass with this change, thanks!
@pablogsal pablogsal force-pushed the pablogsal:bpo-39166 branch from eadf971 to e17ad20 Jan 3, 2020
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member Author

pablogsal commented Jan 3, 2020 •
edited

s/incorrent/incorrect/

Thanks for the catch!

Will correct the other one in a separate PR!
@pablogsal pablogsal force-pushed the pablogsal:bpo-39166 branch from e17ad20 to ff6f82a Jan 3, 2020
@pablogsal
bpo-39166: Fix trace of last iteration of async for loops
Loading status checks…
5e15920
@pablogsal pablogsal force-pushed the pablogsal:bpo-39166 branch from ff6f82a to 5e15920 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees

@pablogsal pablogsal

Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@pablogsal @nedbat @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.