Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39216: Fix constant folding optimization for positional only arguments #17837

Merged
merged 1 commit into from Jan 5, 2020
Merged

bpo-39216: Fix constant folding optimization for positional only arguments #17837

merged 1 commit into from Jan 5, 2020

Conversation

@asottile
Copy link
Contributor

asottile commented Jan 5, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39216
@asottile
Fix constant folding optimization for positional only arguments
Loading status checks…
94f8b8f
@pablogsal
pablogsal approved these changes Jan 5, 2020
View changes
Copy link
Member

pablogsal left a comment

LGTM
@pablogsal pablogsal merged commit b121a4a into python:master Jan 5, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200105.15 succeeded
Details
bedevere/issue-number Issue number 39216 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 5, 2020

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@asottile @miss-islington
Fix constant folding optimization for positional only arguments (pyth…
ad1e7a6 
…onGH-17837)

(cherry picked from commit b121a4a)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17841 is a backport of this pull request to the 3.8 branch.
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Jan 5, 2020

Thanks again, @asottile ! 🎉
@asottile asottile deleted the asottile:posonly_opt_39216 branch Jan 5, 2020
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @asottile
Fix constant folding optimization for positional only arguments (GH-1…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49c108c 
…7837)

(cherry picked from commit b121a4a)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@asottile @gousaiyang
Fix constant folding optimization for positional only arguments (pyth…
fee62ad 
…onGH-17837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@asottile @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.