Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for AsyncMock. #17906

Open
wants to merge 1 commit into
base: master
from
Open

Improve test coverage for AsyncMock. #17906

wants to merge 1 commit into from
+49 −4

Conversation

@tirkarthi
Copy link
Contributor

tirkarthi commented Jan 8, 2020

  • Add test for nested async decorator patch asserting for the order of arguments supplied to function.
  • Add test for side_effect and wraps with a function to AsyncMock.
  • Add test for side_effect with an exception in the iterable to AsyncMock.

Test added with report from https://codecov.io/gh/python/cpython/src/ec0496240aaadfd4d75a80bfffdbb94fa385b7ab/Lib/unittest/mock.py
@tirkarthi
Improve test coverage for AsyncMock.
Loading status checks…
bfaaed1 
* Add test for nested async decorator patch.
* Add test for side_effect and wraps with a function.
* Add test for side_effect with an exception in the iterable.
@tirkarthi tirkarthi requested a review from lisroach Jan 8, 2020
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

tirkarthi commented Jan 8, 2020

FWIW, with the PR the coverage increases from 98.51% to 99.22% : https://codecov.io/gh/python/cpython/src/bfaaed1587756b32b8c7d04f3ad197ee4b3ef51c/Lib/unittest/mock.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisroach lisroach

Assignees
No one assigned
Labels
CLA signed awaiting core review skip issue skip news type-tests
Projects
None yet
Milestone
No milestone
3 participants
@tirkarthi @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.