Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39259: poplib.POP3/POP3_SSL now reject timeout = 0 #17912
Conversation
…mode)
@@ -505,17 +505,17 @@ def server(self, evt, serv): | |||
|
|||
def testTimeoutDefault(self): | |||
self.assertIsNone(socket.getdefaulttimeout()) | |||
socket.setdefaulttimeout(30) | |||
socket.setdefaulttimeout(test_support.SHORT_TIMEOUT) |
This comment has been minimized.
This comment has been minimized.
vstinner
Jan 9, 2020
Member
When I added timeout constants to the test.support module, I decided to leave this test unchanged. I understood that the test doesn't connect to real socket. Or does it? I'm not sure. If it does, LOOPBACK_TIMEOUT is preferred.
This comment has been minimized.
This comment has been minimized.
corona10
Jan 9, 2020
•
Author
Member
Line 107 in eef1b02
As you can see poplib client's constructor actually makes a connection to the server and get a response.
cpython/Lib/test/test_poplib.py
Line 484 in eef1b02
So this test intends to check whether poplib client is set by a global socket timeout and also check whether the connection is succeeded.
This comment has been minimized.
This comment has been minimized.
@vstinner I have made the requested changes; please review again |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 9, 2020
Thanks for making the requested changes! : please review the changes made to this pull request. |
Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-Authored-By: Victor Stinner <vstinner@python.org>
c39b52f
into
python:master
corona10 commentedJan 9, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39259