Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor formatting improvements and fixes to idle.rst #17165

Merged
merged 2 commits into from Jan 5, 2020
Merged

minor formatting improvements and fixes to idle.rst #17165

merged 2 commits into from Jan 5, 2020
+16 −14

Conversation

@taleinat
Copy link
Contributor

taleinat commented Nov 15, 2019

No description provided.

@taleinat
minor formatting improvements and fixes to idle.rst
Verified
This commit was signed with a verified signature.
taleinat Tal Einat
GPG key ID: 613A98AF4C800CDA Learn about signing commits
Loading status checks…
8eaf4ac
@taleinat taleinat requested a review from terryjreedy Nov 15, 2019
@csabella
csabella approved these changes Jan 5, 2020
View changes
Copy link
Contributor

csabella left a comment

Good catch on these! LGTM
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_17165
Loading status checks…
c0a9160
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 5, 2020

Thank you both for the changes and review. I checked that idle.html looks good (better), with no added glitches, in our viewer.
@terryjreedy terryjreedy merged commit d6c08db into python:master Jan 5, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200105.33 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 5, 2020

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17849 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17850 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@taleinat @miss-islington
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
92fde9e 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @taleinat
Minor formatting improvements and fixes to idle.rst (GH-17165)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a065ac 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 6, 2020

GH-17859 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@taleinat @miss-islington
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
d5b1970 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 6, 2020

First 3.7 backport suffered intermittent failure not related to IDLE. Auto-backport tests cannot be restarted, that I know of, so close and start over.
miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @taleinat
Minor formatting improvements and fixes to idle.rst (GH-17165)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
54bcd65 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@taleinat @gousaiyang
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
1dfcc08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@taleinat @terryjreedy @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni
You can’t perform that action at this time.