Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39041: Add GitHub Actions support #17594

Merged
merged 12 commits into from Dec 16, 2019
Merged

bpo-39041: Add GitHub Actions support #17594

merged 12 commits into from Dec 16, 2019
+239 −4

Conversation

@zooba
Copy link
Member

zooba commented Dec 13, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39041
@zooba
Add GitHub Actions support
Loading status checks…
336865a
@zooba zooba changed the title Add GitHub Actions support bpo-39041: Add GitHub Actions support Dec 13, 2019
@zooba zooba added the skip news label Dec 13, 2019
@zooba zooba mentioned this pull request Dec 13, 2019
Closed
@brettcannon
brettcannon approved these changes Dec 13, 2019
View changes
Copy link
Member

brettcannon left a comment

Should make sure to add doc-building workflow. I would also build against -latest for the OSs. And I think you might be able to use ${runs-on} as the title so it states the OS that way.
zooba added 3 commits Dec 13, 2019
@zooba
Enable code coverage and use latest VM images
Loading status checks…
c536670
@zooba
Try fixing labels
Loading status checks…
f3bac4b
@zooba
Revert to static labels
Loading status checks…
8cd2b1a
@zooba

This comment has been minimized.

Sign in to view
Copy link
Member Author

zooba commented Dec 13, 2019

I changed the VM images to "latest", but it still seems best to have static labels. I also added the coverage test run after we know the Ubuntu tests have passed, but I don't know that we'll want the extra delay.

Maybe if I split it into a separate check we can make the coverage run optional? We'll have to merge this one first though. Once I get the docs workflow in then we can do that and iterate on the coverage run.
zooba added 2 commits Dec 13, 2019
@zooba
Add doc task and fix build settings
Loading status checks…
d9b774f
@zooba
Fix check names. Add change to Docs to trigger doc build
Loading status checks…
e01d39c
@brettcannon

This comment has been minimized.

Sign in to view
Copy link
Member

brettcannon commented Dec 13, 2019

Yeah, I would split the coverage run out as a separate thing as we don't rely on it to prevent coverage slippage.
zooba added 2 commits Dec 13, 2019
@zooba
Fix OpenSSL caching
Loading status checks…
14bda3d
@zooba
Fix coverage test command
Loading status checks…
46930ec
@zooba

This comment has been minimized.

Sign in to view
Copy link
Member Author

zooba commented Dec 13, 2019

From my other PR (where I've enabled the builds), it looks like this:
image
zooba added 4 commits Dec 14, 2019
@zooba
Prevent failure if coverage tests fail. Add C coverage
Loading status checks…
548061e
@zooba
Add docs upload.
Loading status checks…
b338981 
Disable C coverage step.
Attempt to fix Python coverage step
@zooba
Fix doc upload syntax
Loading status checks…
c811a8b
@zooba
Split coverage into separate workflow
Loading status checks…
953ac78
@zooba zooba merged commit a76ba36 into python:master Dec 16, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191216.17 succeeded
Details
bedevere/issue-number Issue number 39041 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zooba zooba deleted the zooba:actions branch Dec 16, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@zooba @miss-islington
bpo-39041: Add GitHub Actions support (pythonGH-17594)
0e5216d 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 6, 2020

GH-17868 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 6, 2020

GH-17869 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@zooba @miss-islington
bpo-39041: Add GitHub Actions support (pythonGH-17594)
0036aad 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Jan 6, 2020
@miss-islington @zooba
bpo-39041: Add GitHub Actions support (GH-17594)
Loading status checks…
0048833 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Jan 6, 2020
@miss-islington @zooba
bpo-39041: Add GitHub Actions support (GH-17594)
Loading status checks…
acf5e5f 
(cherry picked from commit a76ba36)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@zooba @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.