Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix link to bpo issue in Changelog #17692
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 24, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
Sorry I missed the CLA before, I have signed it now. |
|
Thanks for the catch. LGTM. |
|
Thanks for the PR @cs-shadow and welcome! LGTM. Based on the description of the change log entry and bpo issues, https://bugs.python.org/issue38688 is definitely the correct issue to link to rather than https://bugs.python.org/issue38668. |
|
LGTM @tirkarthi, I'll leave this for you to merge. :-) |
This comment has been minimized.
This comment has been minimized.
|
Thanks @cs-shadow. Thanks @csabella , hope I followed the correct process with my first merge commit :) |
cs-shadow commentedDec 24, 2019
I think this is rather trivial so didn't create an issue for it. But, please let me know if I am missing something. Thanks!