Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39191: Fix RuntimeWarning in asyncio test #17863

Merged
merged 2 commits into from Jan 7, 2020
Merged

bpo-39191: Fix RuntimeWarning in asyncio test #17863

merged 2 commits into from Jan 7, 2020
+9 −5

Conversation

@asvetlov
Copy link
Contributor

asvetlov commented Jan 6, 2020 •
edited by miss-islington

https://bugs.python.org/issue39191

Automerge-Triggered-By: @asvetlov
@asvetlov
bpo-39191: Fix RuntimeWarning in asyncio test
Loading status checks…
d31c4b7
@asvetlov asvetlov requested a review from 1st1 as a code owner Jan 6, 2020
@tirkarthi
tirkarthi reviewed Jan 6, 2020
View changes
Copy link
Contributor

tirkarthi left a comment

Slightly offtopic, the last patch that caused this warning had a typo _check_runnung which is trivial and can be fixed with this PR.
@asvetlov
Fix typo
Loading status checks…
3c1742d
@asvetlov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

asvetlov commented Jan 7, 2020

You are right. I've fixed the typo.
@tirkarthi
tirkarthi approved these changes Jan 7, 2020
View changes
Copy link
Contributor

tirkarthi left a comment

LGTM. Thanks.
@miss-islington miss-islington merged commit 10ac0cd into python:master Jan 7, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200107.21 succeeded
Details
bedevere/issue-number Issue number 39191 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 7, 2020

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 7, 2020

Sorry, @asvetlov, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 10ac0cded26d91c3468e5e5a87cecad7fc0bcebd 3.8
@miss-islington miss-islington self-assigned this Jan 7, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 7, 2020

Sorry @asvetlov, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 10ac0cded26d91c3468e5e5a87cecad7fc0bcebd 3.7
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 7, 2020

GH-17894 is a backport of this pull request to the 3.8 branch.
asvetlov added a commit to asvetlov/cpython that referenced this pull request Jan 7, 2020
@asvetlov
[3.8] bpo-39191: Fix RuntimeWarning in asyncio test (pythonGH-17863)
1b7539b 
https://bugs.python.org/issue39191.
(cherry picked from commit 10ac0cd)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 7, 2020

GH-17895 is a backport of this pull request to the 3.7 branch.
@asvetlov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

asvetlov commented Jan 7, 2020

Thanks for the review, @tirkarthi
@asvetlov asvetlov deleted the asvetlov:bpo-39191 branch Jan 7, 2020
asvetlov added a commit that referenced this pull request Jan 7, 2020
@asvetlov
[3.8] bpo-39191: Fix RuntimeWarning in asyncio test (GH-17863) (#17894)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4112a3d 
https://bugs.python.org/issue39191.
(cherry picked from commit 10ac0cd)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@1st1 1st1

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants
@asvetlov @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni
You can’t perform that action at this time.