Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39161: Document multi-phase init modules under Py_NewInterpreter() #17896
+35
−17
Conversation
This also adds a stronger warning against sharing objects between (sub-)interpreters.
ncoghlan
changed the title
|
LGTM, just a couple of copy-editing comments inline. |
This comment has been minimized.
This comment has been minimized.
|
Note: I also fixed up the b.p.o links to refer the right issue (this had been confused with the VectorCall one). |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 9, 2020
|
Sorry, I can't merge this PR. Reason: |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 9, 2020
|
Thanks @encukou for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 9, 2020
pythonGH-17896) \+ this also adds a stronger warning against sharing objects between (sub-)interpreters. https://bugs.python.org/issue39161 (cherry picked from commit 6c5d661) Co-authored-by: Petr Viktorin <encukou@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 9, 2020
|
GH-17918 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 9, 2020
GH-17896) \+ this also adds a stronger warning against sharing objects between (sub-)interpreters. https://bugs.python.org/issue39161 (cherry picked from commit 6c5d661) Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
encukou commentedJan 7, 2020
•
edited by miss-islington
+ this also adds a stronger warning against sharing objects between (sub-)interpreters.
https://bugs.python.org/issue39161
Automerge-Triggered-By: @encukou