Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[3.8] bpo-16575: Disabled checks for union types being passed by value. (GH-17960) #17964
+20
−1
Conversation
…-17960) Although the underlying libffi issue remains open, adding these checks have caused problems in third-party projects which are in widespread use. See the issue for examples. The corresponding tests have also been skipped. (cherry picked from commit c12440c) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
This comment has been minimized.
This comment has been minimized.
|
@vsajip: Status check is done, and it's a success |
vsajip
merged commit eb9ba2f
into
python:3.8
9 checks passed
9 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
"skip news" label found
This comment has been minimized.
This comment has been minimized.
|
@vsajip: Status check is done, and it's a success |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@vsajip: Status check is done, and it's a success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedJan 12, 2020
•
edited by bedevere-bot
Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.
The corresponding tests have also been skipped.
(cherry picked from commit c12440c)
Co-authored-by: Vinay Sajip vinay_sajip@yahoo.co.uk
https://bugs.python.org/issue16575