Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39308: Make _tp_cache typed #17974

Open
wants to merge 2 commits into
base: master
from

Conversation

@kornicameister
Copy link

kornicameister commented Jan 12, 2020

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 12, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kornicameister

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@kornicameister

This comment has been minimized.

Copy link
Author

kornicameister commented Jan 12, 2020

ok, haven't exactly read entire contributing docs and missed News bit, I will deal with that shortly.
I am more worried about lack of CLA which I have signed just yesterday :/


just signed CLA again, changed bugs.python.org username to match GH account (not even sure if that was needed, better be sorry though). Not sure if there's anything else I can now, I thought I've completed process correctly.

Copy link
Member

gvanrossum left a comment

Looks good. CLA usually takes a business day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.