Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39303: [WIP] Refactor cmd module #17951

Open
wants to merge 6 commits into
base: master
from
Open

bpo-39303: [WIP] Refactor cmd module #17951

wants to merge 6 commits into from
+199 −108

Conversation

@dan1994
Copy link

dan1994 commented Jan 11, 2020 •
edited by bedevere-bot

Hello everyone!

As stated in the issue, I'm new to contributing to open source, but would love to contribute to python!

Any comments about styling, testing, or even things like breaking this issue into smaller issues would be highly appreciated!

https://bugs.python.org/issue39303
dan1994 added 6 commits Jan 10, 2020
@dan1994
Refactored __init__ to look simpler
b4af8ae
@dan1994
Split cmdloop function to different functions and added some simple t…
e2bf668 
…ests for them
@dan1994
Refactored parseline
7bdc3ae
@dan1994
Refactored onecmd. It seems that we register ! as an alias to shell w…
9dfcdf5 
…/o providing a default implementation. This makes us preform ugly checks that would otherwise be unnecessary. Also, it would be pretty simple to add a generic alias mechanism instead of allowing only the built in ? and !
@dan1994
Small refactors
ab311e5
@dan1994
Refactored do_help method
Loading status checks…
03e5823
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 11, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@dan1994

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@corona10
corona10 suggested changes Jan 11, 2020
View changes
Copy link
Member

corona10 left a comment

https://docs.python.org/3.9/library/cmd.html

Thanks for the contribution, however, this change will affect the public APIs of the cmd module.
This kind of work should be processed after the discussion with core developers.
@dan1994

This comment has been minimized.

Sign in to view
Copy link
Author

dan1994 commented Jan 11, 2020 •
edited

Where should such a discussion be held, and how would I contact the core developers?
In any case, at least for the time being, I preserve existing APIs, and only partition into functions (although in my opinion there are some changes that will benefit the module).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
CLA not signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@dan1994 @the-knights-who-say-ni @corona10 @bedevere-bot
You can’t perform that action at this time.