Fix Documentation for PyType_GetFlags #10758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: bpo-16086. |
|
@serhiy-storchaka I didn't know how much explanation you wanted in the "The return type is now |
serhiy-storchaka
approved these changes
Nov 29, 2018
|
Thanks @eduardo-elizondo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10789 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2018
PyType_GetFlags() return type is unsigned long, not long. (cherry picked from commit 9fbcfc0) Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
|
GH-10790 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2018
PyType_GetFlags() return type is unsigned long, not long. (cherry picked from commit 9fbcfc0) Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
vstinner
pushed a commit
that referenced
this pull request
Nov 29, 2018
vstinner
pushed a commit
that referenced
this pull request
Nov 29, 2018
|
Thanks @eduardo-elizondo, I merged your change in master, and backported it to 3.6 and 3.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change, no need for bug report or NEWS