bpo-35310: Clear select() lists before returning upon EINTR #10877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note pull request #10700; one of these should be merged, the other declined -- as they fix the same problem with different approaches. |
vstinner
reviewed
Dec 3, 2018
Misc/NEWS.d/next/Library/2018-12-03-19-45-00.bpo-35310.9k28gR.rst
Outdated
Show resolved
Hide resolved
oranav
force-pushed
the
fix-bpo-35310-empty-lists
branch
from
f681e13 to
d6d788e
Compare
vstinner
reviewed
Dec 4, 2018
oranav
force-pushed
the
fix-bpo-35310-empty-lists
branch
from
d6d788e to
7f55aa0
Compare
|
@vstinner I believe the CI build test failed randomly; can you re-run it please? |
|
Please rebase your change on top of master to retrieve the test_urllib2net fix: https://mail.python.org/pipermail/python-dev/2018-December/155928.html |
select() calls are retried on EINTR (per PEP 475). However, if a timeout was provided and the deadline has passed after running the signal handlers, we should clear rlist, wlist and xlist since select(2) left them unmodified.
oranav
force-pushed
the
fix-bpo-35310-empty-lists
branch
from
7f55aa0 to
76ad1e9
Compare
|
Done, tests passed |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…-10877) select() calls are retried on EINTR (per PEP 475). However, if a timeout was provided and the deadline has passed after running the signal handlers, rlist, wlist and xlist should be cleared since select(2) left them unmodified. (cherry picked from commit 7f52415) Co-authored-by: Oran Avraham <252748+oranav@users.noreply.github.com>
|
GH-10948 is a backport of this pull request to the 3.6 branch. |
|
GH-10949 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…-10877) select() calls are retried on EINTR (per PEP 475). However, if a timeout was provided and the deadline has passed after running the signal handlers, rlist, wlist and xlist should be cleared since select(2) left them unmodified. (cherry picked from commit 7f52415) Co-authored-by: Oran Avraham <252748+oranav@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
select() calls are retried on EINTR (per PEP 475). However, if a timeout was provided and the deadline has passed after running the signal handlers, rlist, wlist and xlist should be cleared since select(2) left them unmodified. (cherry picked from commit 7f52415) Co-authored-by: Oran Avraham <252748+oranav@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
select() calls are retried on EINTR (per PEP 475). However, if a timeout was provided and the deadline has passed after running the signal handlers, rlist, wlist and xlist should be cleared since select(2) left them unmodified. (cherry picked from commit 7f52415) Co-authored-by: Oran Avraham <252748+oranav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select() calls are retried on EINTR (per PEP 475). However, if a
timeout was provided and the deadline has passed after running the
signal handlers, we should clear rlist, wlist and xlist since select(2)
left them unmodified.
https://bugs.python.org/issue35310