Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35426: Eliminate race condition in test_interprocess_signal #11087

Merged
merged 1 commit into from Dec 11, 2018
Merged

bpo-35426: Eliminate race condition in test_interprocess_signal #11087

merged 1 commit into from Dec 11, 2018

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 10, 2018 •
edited by bedevere-bot

@pablogsal pablogsal added tests Tests in the Lib/test dir skip news labels Dec 10, 2018
@pablogsal pablogsal self-assigned this Dec 10, 2018
@pablogsal pablogsal requested a review from vstinner Dec 10, 2018
eamanu
eamanu approved these changes Dec 10, 2018
View changes
Copy link
Contributor

@eamanu eamanu left a comment

lgtm

vstinner
vstinner approved these changes Dec 11, 2018
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@pablogsal pablogsal merged commit 2ab2afd into python:master Dec 11, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Dec 11, 2018

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo35426 branch Dec 11, 2018
@bedevere-bot
Copy link

bedevere-bot commented Dec 11, 2018

GH-11113 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2018
@pablogsal @miss-islington
bpo-35426: Eliminate race condition in test_interprocess_signal (pyth…
8483b18 
…onGH-11087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 11, 2018

GH-11114 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2018
@pablogsal @miss-islington
bpo-35426: Eliminate race condition in test_interprocess_signal (pyth…
ed89a4b 
…onGH-11087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Dec 11, 2018
@miss-islington @pablogsal
bpo-35426: Eliminate race condition in test_interprocess_signal (GH-1…
f7404a5 
…1087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Dec 11, 2018
@miss-islington @pablogsal
bpo-35426: Eliminate race condition in test_interprocess_signal (GH-1…
869e23e 
…1087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.
(cherry picked from commit 2ab2afd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@eamanu eamanu

Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pablogsal @miss-islington @bedevere-bot @vstinner @eamanu @the-knights-who-say-ni