Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify control flow when exiting the interpreter. #17756

Merged
merged 1 commit into from Jan 13, 2020
Merged

Simplify control flow when exiting the interpreter. #17756

merged 1 commit into from Jan 13, 2020
+5 −42

Conversation

@markshannon
Copy link
Contributor

markshannon commented Dec 30, 2019

Skip the stack emptying step for RETURN_VALUE, as the compiler now ensures that the stack is empty.

Remove test that generates invalid bytecode.
Maybe we should have a bytecode verifier, but that's not the job of the interpreter.

No change in behaviour, so no news or BPO issue needed.
@markshannon
Cleanup exit code for interpreter.
Loading status checks…
fa9c5d3
@pablogsal
pablogsal approved these changes Dec 30, 2019
View changes
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 30, 2019

as the compiler now ensures that the stack is empty

Out of curiosity, in which PR/issue was this changed?
@markshannon

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

markshannon commented Dec 30, 2019

#6641
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 30, 2019

#6641

Thanks, Mark!
@markshannon markshannon merged commit e7c9f4a into python:master Jan 13, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191230.25 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markshannon markshannon deleted the markshannon:cleanup-interpreter-exit branch Jan 13, 2020
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 13, 2020
@sthagen
Merge pull request #172 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
844d0ad 
Cleanup exit code for interpreter. (pythonGH-17756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
4 participants
@markshannon @pablogsal @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.