Skip to content

bpo-35250: Correct a minor argument name in docs #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2018
Merged

bpo-35250: Correct a minor argument name in docs #10565

merged 2 commits into from
Nov 16, 2018

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Nov 16, 2018 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 16, 2018
@srinivasreddy
Copy link
Contributor Author

needs backport for 2.7, 3.6 and 3.7

@serhiy-storchaka
Copy link
Member

What about other functions? onrelease(), ondrag(), etc?

@srinivasreddy
Copy link
Contributor Author

@serhiy-storchaka Done. Thanks for the catch!!

serhiy-storchaka
serhiy-storchaka reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings should be fixed too.

@serhiy-storchaka serhiy-storchaka merged commit 4edeaea into python:master Nov 16, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2018
@srinivasreddy @miss-islington
bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (pyth…
23812b3 
…onGH-10565)

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

GH-10571 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-10572 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @srinivasreddy and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4edeaeac4c194ba5d09187640b5cfca5e03be617 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2018
@srinivasreddy @miss-islington
bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (pyth…
c975c26 
…onGH-10565)

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 16, 2018
@miss-islington @srinivasreddy
bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (GH-1…
0461c3b 
…0565)

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 16, 2018
@miss-islington @srinivasreddy
bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (GH-1…
8856246 
…0565)

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@srinivasreddy srinivasreddy deleted the 35250 branch November 16, 2018 14:50
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Dec 5, 2018
@srinivasreddy @serhiy-storchaka
[2.7] bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (…
a1befbb 
…pythonGH-10565).

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

GH-10943 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Dec 5, 2018
@serhiy-storchaka @srinivasreddy
[2.7] bpo-35250: Correct argument name "num" -> "btn" in turtle docs. (…
abe74fe 
…GH-10565). (GH-10943)

(cherry picked from commit 4edeaea)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinivasreddy @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni