Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numbered lists in stdtypes.rst #10989

Merged

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 6, 2018

Index entries don't play well with lists: after each index entry a new list is created. Fix this by having the index entries before the lists. Granted, this is not ideal.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 6, 2018
@serhiy-storchaka serhiy-storchaka self-requested a review Dec 6, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 9, 2018

Good catch!

@andresdelfino andresdelfino deleted the stdtypes-numbered-list branch Dec 9, 2018
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 10, 2018

@serhiy-storchaka Perhaps we can backport this to 3.7?

@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2018

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2018

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2018

GH-11083 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2018
(cherry picked from commit de9e9b4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2018
(cherry picked from commit de9e9b4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2018

GH-11084 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Dec 10, 2018
(cherry picked from commit de9e9b4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Dec 10, 2018
(cherry picked from commit de9e9b4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants