bpo-29636: json.tool: Add document for indentation options. #17482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
commented
Dec 6, 2019
| Mutually exclusive options for whitespace control | ||
|
|
||
| .. versionadded:: 3.9 | ||
|
|
There was a problem hiding this comment.
@wimglenn does this documentation look okay? I combined multiple arguments into a single line (not sure if that violates convention or is okay)
dhimmel
commented
Dec 6, 2019
Lib/json/tool.py
Outdated
| @@ -31,7 +31,8 @@ def main(): | |||
| parser.add_argument('--sort-keys', action='store_true', default=False, | |||
| help='sort the output of dictionaries alphabetically by key') | |||
| parser.add_argument('--json-lines', action='store_true', default=False, | |||
| help='parse input using the jsonlines format') | |||
| help='parse input using the jsonlines format. ' | |||
| 'Use with --no-indent or --compact to produce valid jsonlines output.') | |||
There was a problem hiding this comment.
@hongweipeng (author of #10051): do you think this is a worthwhile and accurate addition to the documentation now that indentation options are supported?
As per http://jsonlines.org/: > JSON Lines is a convenient format for storing structured data
trailing newlines were previously ignored due to .splitlines Probably is better to test for this to ensure any future change in behavior is intentional.
methane
changed the title
methane
approved these changes
Dec 7, 2019
|
Rendered documentation available at https://docs.python.org/3.9/library/json.html#cmdoption-json-tool-indent I forgot a period after "whitespace control" ): |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…-17482) And updated test to use subprocess.run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#345 added indentation options for the
json.toolcommand line utility. This PR follows up with some additional modifications that I didn't have time to put in the previous PR before it was merged.https://bugs.python.org/issue29636
CC @methane