Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33807: Add Python 3.7 to .github/CONTRIBUTING.rst #7532

Merged
merged 1 commit into from Jun 8, 2018
Merged

bpo-33807: Add Python 3.7 to .github/CONTRIBUTING.rst #7532

merged 1 commit into from Jun 8, 2018

Conversation

@SuriyaaKudoIsc
Copy link
Contributor

SuriyaaKudoIsc commented Jun 8, 2018 •
edited by bedevere-bot

Hello @python community,

This is my first Python pull request! 😄

This solves bpo-33807: https://bugs.python.org/issue33807.

--Suriyaa Sundararuban (My Python profile) (My Bugs Profile)

https://bugs.python.org/issue33807
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jun 8, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!
@SuriyaaKudoIsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SuriyaaKudoIsc commented Jun 8, 2018 •
edited

✅ Ok. I filled out and signed the PSF contributor form. We need to wait at least one US business day to ask for a CLA recheck.
@berkerpeksag
berkerpeksag reviewed Jun 8, 2018
View changes
.github/CONTRIBUTING.rst Outdated
@@ -6,7 +6,7 @@ Build Status

- master

+ `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_
+ `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_

This comment has been minimized.

Sign in to view
Copy link
@berkerpeksag

berkerpeksag Jun 8, 2018

Member

I think the correct link is either http://buildbot.python.org/all/#/grid?branch=master&tag=stable or http://buildbot.python.org/all/#/builders?tags=%2Bstable&tags=%2B3.x

@zware which one is better?

This comment has been minimized.

Sign in to view
Copy link
@zware

zware Jun 8, 2018

Member

"better" is a pure judgement call, unfortunately. I prefer the builders page, but I believe others prefer the grid page. The grid page does at least attempt to match up builds with commits, so that one may actually be better.
.github/CONTRIBUTING.rst Outdated
@@ -6,7 +6,7 @@ Build Status

- master

+ `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_
+ `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_

- 3.6

This comment has been minimized.

Sign in to view
Copy link
@berkerpeksag

berkerpeksag Jun 8, 2018

Member

You also need to fix the links of 3.6 and 2.7 branches.

This comment has been minimized.

Sign in to view
Copy link
@SuriyaaKudoIsc

SuriyaaKudoIsc Jun 8, 2018

Author Contributor

@berkerpeksag 👍 Yes. I didn't find links that matches.
@zware
zware requested changes Jun 8, 2018
View changes
Copy link
Member

zware left a comment

I was actually able to restore the /3.x.stable/ (and similar) redirects, so the links here now work basically as expected. However, we do need to add 3.7 to this list, which this PR could be repurposed to do :)
.github/CONTRIBUTING.rst Outdated
@@ -6,7 +6,7 @@ Build Status

- master

+ `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_
+ `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_

This comment has been minimized.

Sign in to view
Copy link
@zware

zware Jun 8, 2018

Member

"better" is a pure judgement call, unfortunately. I prefer the builders page, but I believe others prefer the grid page. The grid page does at least attempt to match up builds with commits, so that one may actually be better.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 8, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@SuriyaaKudoIsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SuriyaaKudoIsc commented Jun 8, 2018

@zware 👍 Ok. I'm going to add 3.7.
@SuriyaaKudoIsc
bpo-33807: Add Python 3.7 to '.github/CONTRIBUTING.rst'
Verified
This commit was signed with a verified signature.
SuriyaaKudoIsc Suriyaa Sundararuban
GPG key ID: 7C2B2155FDDD96B0 Learn about signing commits
Loading status checks…
6f8433d
@SuriyaaKudoIsc SuriyaaKudoIsc changed the title bpo-33807: Fix 'Stable buildbots' link for master-branch bpo-33807: Add Python 3.7 to .github/CONTRIBUTING.rst Jun 8, 2018
@SuriyaaKudoIsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SuriyaaKudoIsc commented Jun 8, 2018 •
edited

@zware I updated the pull request (change pr title & rebase Git commits).
@SuriyaaKudoIsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SuriyaaKudoIsc commented Jun 8, 2018

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 8, 2018

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.
@zware
zware approved these changes Jun 8, 2018
View changes
Copy link
Member

zware left a comment

LGTM!
@berkerpeksag
berkerpeksag approved these changes Jun 8, 2018
View changes
@SuriyaaKudoIsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SuriyaaKudoIsc commented Jun 8, 2018

:shipit: 😁
@zware zware merged commit 9e6685e into python:master Jun 8, 2018
9 checks passed
9 checks passed
VSTS: Linux-PR Linux-PR_20180608.40 succeeded
Details
VSTS: Linux-PR-Coverage Linux-PR-Coverage_20180608.51 succeeded
Details
VSTS: Windows-PR Windows-PR_20180608.40 succeeded
Details
VSTS: docs docs_20180608.72 succeeded
Details
VSTS: macOS-PR macOS-PR_20180608.40 succeeded
Details
bedevere/issue-number Issue number 33807 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 8, 2018

Thanks @SuriyaaKudoIsc for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@zware

This comment has been minimized.

Sign in to view
Copy link
Member

zware commented Jun 8, 2018

@SuriyaaKudoIsc Thanks for your contribution!
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@SuriyaaKudoIsc @miss-islington
bpo-33807: Add Python 3.7 buildbot link to '.github/CONTRIBUTING.rst' (…
707b342 
…pythonGH-7532)

(cherry picked from commit 9e6685e)

Co-authored-by: Suriyaa ✌️️ <isc.suriyaa@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 8, 2018

GH-7540 is a backport of this pull request to the 3.7 branch.
@SuriyaaKudoIsc SuriyaaKudoIsc deleted the SuriyaaKudoIsc:fix-issue-33807 branch Jun 8, 2018
miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @SuriyaaKudoIsc
bpo-33807: Add Python 3.7 buildbot link to '.github/CONTRIBUTING.rst' (…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
552c1bc 
…GH-7532)

(cherry picked from commit 9e6685e)

Co-authored-by: Suriyaa ✌️️ <isc.suriyaa@gmail.com>
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2018
@SuriyaaKudoIsc @lisroach
bpo-33807: Add Python 3.7 buildbot link to '.github/CONTRIBUTING.rst' (…
122050c 
…pythonGH-7532)
yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@SuriyaaKudoIsc @yahya-abou-imran
bpo-33807: Add Python 3.7 buildbot link to '.github/CONTRIBUTING.rst' (…
c818577 
…pythonGH-7532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

@zware zware

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@SuriyaaKudoIsc @the-knights-who-say-ni @bedevere-bot @miss-islington @zware @berkerpeksag
You can’t perform that action at this time.