Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-1635741: Port _json extension module to multiphase initialization(PEP 489) #17835

Merged
merged 7 commits into from Jan 15, 2020
Merged

bpo-1635741: Port _json extension module to multiphase initialization(PEP 489) #17835

merged 7 commits into from Jan 15, 2020
+31 −23

Conversation

@shihai1991
Copy link
Contributor

shihai1991 commented Jan 5, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue1635741
hai shi
port _json extension module to multiphase initialization(PEP 489)
Loading status checks…
d234888
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
658d1a7
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 6, 2020

cc @encukou @Dormouse759
@vstinner
vstinner reviewed Jan 9, 2020
View changes
Modules/_json.c Outdated Show resolved Hide resolved
...NEWS.d/next/Core and Builtins/2020-01-05-13-40-08.bpo-1635741.QRTJVC.rst Outdated Show resolved Hide resolved
shi hai and others added 5 commits Jan 9, 2020
shi hai
Fix refcount bug
768b489
shi hai
Merge branch 'bpo_1635741' of https://github.com/shihai1991/cpython i…
Loading status checks…
d2cbd2e 
…nto bpo_1635741
@shihai1991 @vstinner
Update Misc/NEWS.d/next/Core and Builtins/2020-01-05-13-40-08.bpo-163…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
96d5f35 
…5741.QRTJVC.rst

Co-Authored-By: Victor Stinner <vstinner@python.org>
@shihai1991
Merge branch 'bpo_1635741' of https://github.com/shihai1991/cpython i…
078584c 
…nto bpo_1635741
@shihai1991
Merge branch 'bpo_1635741' of https://github.com/shihai1991/cpython i…
Loading status checks…
d0ca663 
…nto bpo_1635741
@vstinner
vstinner approved these changes Jan 15, 2020
View changes
Copy link
Member

vstinner left a comment

LGTM.
@vstinner vstinner merged commit ed154c3 into python:master Jan 15, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200110.1 succeeded
Details
bedevere/issue-number Issue number 1635741 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.