New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35486: Note Py3.6 import system API requirement change #11540
bpo-35486: Note Py3.6 import system API requirement change #11540
Conversation
Note that I've flagged this for Python 3.6 so that https://docs.python.org/3.6/whatsnew/3.6.html#porting-to-python-3-6 will get updated. (cc @ned-deily) |
@python/import-team One thing to check here is that I think I'm right that anyone writing meta_path importers and PathFinder path hooks still doesn't need to worry about raising However, it's also possible that this change may uncover latent plugin defects where the plugin is raising ImportError directly when it should be returning |
If you want to be extra-thorough, the Approximating Otherwise LGTM and your assessment that nothing in |
@brettcannon Example updated. It turns out that just setting |
@ncoghlan: Status check is done, and it's a success |
Thanks @ncoghlan for the PR |
GH-11587 is a backport of this pull request to the 3.7 branch. |
…11540) While the introduction of ModuleNotFoundError was fully backwards compatible on the import API consumer side, folks providing alternative implementations of `__import__` need to make an update to be forward compatible with clients that start relying on the new subclass. https://bugs.python.org/issue35486 (cherry picked from commit cee29b4) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
…11540) While the introduction of ModuleNotFoundError was fully backwards compatible on the import API consumer side, folks providing alternative implementations of `__import__` need to make an update to be forward compatible with clients that start relying on the new subclass. https://bugs.python.org/issue35486 (cherry picked from commit cee29b4) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
GH-11588 is a backport of this pull request to the 3.6 branch. |
While the introduction of ModuleNotFoundError was fully backwards compatible on the import API consumer side, folks providing alternative implementations of `__import__` need to make an update to be forward compatible with clients that start relying on the new subclass. https://bugs.python.org/issue35486 (cherry picked from commit cee29b4) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
…GH-11588) While the introduction of ModuleNotFoundError was fully backwards compatible on the import API consumer side, folks providing alternative implementations of `__import__` need to make an update to be forward compatible with clients that start relying on the new subclass. https://bugs.python.org/issue35486 (cherry picked from commit cee29b4) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
While the introduction of ModuleNotFoundError was fully backwards
compatible on the import API consumer side, folks providing alternative
implementations of
__import__
need to make an update to beforward compatible with clients that start relying on the new subclass.
https://bugs.python.org/issue35486