Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-16575: Disabled checks for union types being passed by value. #17960

Merged
merged 1 commit into from Jan 12, 2020
Merged

bpo-16575: Disabled checks for union types being passed by value. #17960

merged 1 commit into from Jan 12, 2020
+20 −1

Conversation

@vsajip
Copy link
Member

vsajip commented Jan 12, 2020 •
edited by bedevere-bot

Although the underlying libffi issue remains open, adding these checks have caused problems in third-party projects which are in widespread use. See the issue for examples.

The corresponding tests have also been skipped.

https://bugs.python.org/issue16575
@vsajip
bpo-16575: Disabled checks for union types being passed by value.
Loading status checks…
53dcc46 
Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
@vsajip vsajip merged commit c12440c into python:master Jan 12, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200112.12 succeeded
Details
bedevere/issue-number Issue number 16575 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vsajip vsajip deleted the vsajip:fix-16575 branch Jan 12, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@vsajip @miss-islington
bpo-16575: Disabled checks for union types being passed by value. (py…
85b8bdb 
…thonGH-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

GH-17964 is a backport of this pull request to the 3.8 branch.
vsajip added a commit that referenced this pull request Jan 12, 2020
@miss-islington @vsajip
bpo-16575: Disabled checks for union types being passed by value. (GH…
Loading status checks…
eb9ba2f 
…-17960) (GH-17964)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.

(cherry picked from commit c12440c)
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

Sorry, @vsajip, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c12440c371025bea9c3bfb94945f006c486c2c01 3.7
vsajip added a commit that referenced this pull request Jan 12, 2020
@vsajip
bpo-16575: Disabled checks for union types being passed by value. (GH…
d9132a4 
…-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)
vsajip added a commit to vsajip/cpython that referenced this pull request Jan 12, 2020
@vsajip
[3.7] bpo-16575: Disabled checks for union types being passed by valu…
b7822cb 
…e. (pythonGH-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped..
(cherry picked from commit c12440c)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

GH-17970 is a backport of this pull request to the 3.7 branch.
vsajip added a commit that referenced this pull request Jan 12, 2020
@vsajip
[3.7] bpo-16575: Disabled checks for union types being passed by valu…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9dbf5d3 
…e. (GH-17960) (GH-17970)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)
This was referenced Jan 14, 2020
Open
Open
@airelil airelil mentioned this pull request Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsajip vsajip

Labels
CLA signed skip news type-bugfix
Projects
None yet
Milestone
No milestone
4 participants
@vsajip @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.