Skip to content
Permalink
Branch: 3.8
Commits on Jan 16, 2020
  1. bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018)

    miss-islington and oz123 committed Jan 16, 2020
    The previous double colon was wrongly place directly after Therefore.
    Which produced a block without syntax highlighting. This fixes it
    by separating the double colon from the text. As a result, sphinx now
    properly highlights the python code.
    
    https://bugs.python.org/issue39348
    (cherry picked from commit fad8b56)
    
    Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
Commits on Jan 15, 2020
  1. [3.8] Fix typo in multiprocessing.pool.AsyncResult.successful doc. (G…

    miss-islington committed Jan 15, 2020
    …H-17932) (GH-18015)
    
    Since 3.7 `successful` raises a `ValueError` as explained in the next text block from the documentation:
    
    _Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError._
    
    No issue associated with this PR.
    Should be backported in 3.7 and 3.8.
    (cherry picked from commit dc0284e)
    
    
    Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
    
    Automerge-Triggered-By: @pitrou
  2. Fix compiler warning on Windows (GH-18012)

    miss-islington and ammaraskar committed Jan 15, 2020
    Python-ast.h contains a macro named Yield that conflicts with the Yield macro
    in Windows system headers. While Python-ast.h has an "undef Yield" directive
    to prevent this, it means that Python-ast.h must be included before Windows
    header files or we run into a re-declaration warning. In commit c96be81
    an include for pycore_pystate.h was added which indirectly includes Windows
    header files. In this commit we re-order the includes to fix this warning.
    (cherry picked from commit e92d393)
    
    Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
Commits on Jan 14, 2020
  1. Fix documentation in code.py (GH-17988)

    miss-islington and kylepollina committed Jan 14, 2020
    (cherry picked from commit b4cdb3f)
    
    Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
  2. [3.8] bpo-39033: Fix NameError in zipimport during hash validation (G…

    tirkarthi authored and miss-islington committed Jan 14, 2020
    …H-17588) (GH-17642)
    
    Fix `NameError` in `zipimport` during hash validation and add a regression test.
    
    (cherry picked from commit 79f02fe)
    
    
    
    https://bugs.python.org/issue39033
Commits on Jan 13, 2020
  1. bpo-39310: Update sys.float_info documentation (GH-17982)

    vstinner committed Jan 13, 2020
    Specify that sys.float_info.min is only the minimum normalized float.
  2. bpo-39307: Fix memory leak on error path in parsetok (GH-17953)

    miss-islington and alexhenrie committed Jan 13, 2020
    (cherry picked from commit 7ba6f18)
    
    Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
Commits on Jan 12, 2020
  1. [3.8] Fix typos in Misc/NEWS.d (GH-17930)

    toonarmycaptain authored and asvetlov committed Jan 12, 2020
  2. bpo-3530: Add advice on when to correctly use fix_missing_locations i…

    miss-islington and isidentical committed Jan 12, 2020
    …n the AST docs (GH-17172)
    
    Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
    (cherry picked from commit 6680f4a)
    
    Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
  3. bpo-38293: Allow shallow and deep copying of property objects (GH-16438)

    miss-islington and GudniNatan committed Jan 12, 2020
    Copying property objects results in a TypeError. Steps to reproduce:
    
    ```
    >>> import copy
    >>> obj = property()
    >>> copy.copy(obj)
    ````
    
    This affects both shallow and deep copying.
    My idea for a fix is to add property objects to the list of "atomic" objects in the copy module.
    These already include types like functions and type objects.
    
    I also added property objects to the unit tests test_copy_atomic and test_deepcopy_atomic. This is my first PR, and it's highly likely I've made some mistake, so please be kind :)
    
    https://bugs.python.org/issue38293
    (cherry picked from commit 9f3fc6c)
    
    Co-authored-by: Guðni Natan Gunnarsson <1493259+GudniNatan@users.noreply.github.com>
  4. bpo-16575: Disabled checks for union types being passed by value. (GH…

    miss-islington authored and vsajip committed Jan 12, 2020
    …-17960) (GH-17964)
    
    Although the underlying libffi issue remains open, adding these
    checks have caused problems in third-party projects which are in
    widespread use. See the issue for examples.
    
    The corresponding tests have also been skipped.
    
    (cherry picked from commit c12440c)
  5. bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-1…

    miss-islington and aeros committed Jan 12, 2020
    …6552)
    
    Motivation for this PR (comment from @vstinner in bpo issue):
    ```
    Warning seen o AMD64 Ubuntu Shared 3.x buildbot:
    https://buildbot.python.org/all/GH-/builders/141/builds/2593
    
    test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ...
    Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
    ```
    The following implementation details for the new method are TBD:
    
    1) Public vs private
    
    2) Inclusion in `close()`
    
    3) Name
    
    4) Coroutine vs subroutine method
    
    5) *timeout* parameter
    
    If it's a private method, 3, 4, and 5 are significantly less important.
    
    I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this.
    
    https://bugs.python.org/issue38356
    (cherry picked from commit 0ca7cc7)
    
    Co-authored-by: Kyle Stanley <aeros167@gmail.com>
  6. bpo-39233: Update positional-only section in the glossary (GH-17874)

    miss-islington and pablogsal committed Jan 12, 2020
    https://bugs.python.org/issue39233
    (cherry picked from commit 9a669d5)
    
    Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Commits on Jan 11, 2020
  1. bpo-39297: Update for importlib_metadata 1.4. (GH-17947) (GH-17952)

    miss-islington and jaraco committed Jan 11, 2020
    * bpo-39297: Update for importlib_metadata 1.4. Includes performance updates.
    
    * 📜🤖 Added by blurb_it.
    
    * Update blurb
    
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
    (cherry picked from commit 136735c)
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
  2. Fix host in address of socket.create_server example. (GH-17706)

    miss-islington and tirkarthi committed Jan 11, 2020
    Host as None in address raises TypeError since it should be string, bytes or bytearray.
    (cherry picked from commit 43682f1)
    
    Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Commits on Jan 10, 2020
  1. [3.8] Add test cases for dataclasses. (GH-17909) (GH-17919)

    miss-islington committed Jan 10, 2020
    * Add test cases for dataclasses.
    
    * Add test for repr output of field.
    * Add test for ValueError to be raised when both default and default_factory are passed.
    (cherry picked from commit eef1b02)
    
    
    Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
    
    Automerge-Triggered-By: @ericvsmith
Commits on Jan 9, 2020
  1. bpo-39235: Fix end location for genexp in call args (GH-17925)

    miss-islington and gvanrossum committed Jan 9, 2020
    The fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites.
    
    https://bugs.python.org/issue39235
    (cherry picked from commit a796d8e)
    
    Co-authored-by: Guido van Rossum <guido@python.org>
  2. Fix typo in test's docstring (GH-17856) (GH-17923)

    2 people authored and tirkarthi committed Jan 9, 2020
    * Fix typo in test's docstring. contination -> continuation.
    (cherry picked from commit 2f65aa4)
    
    Co-authored-by: Daniel Hahler <git@thequod.de>
    
    Co-authored-by: Daniel Hahler <github@thequod.de>
  3. bpo-25172: Reduce scope of crypt import tests (GH-17881)

    miss-islington and zooba committed Jan 9, 2020
    (cherry picked from commit ed36781)
    
    Co-authored-by: Steve Dower <steve.dower@python.org>
  4. bpo-39161: Document multi-phase init modules under Py_NewInterpreter() (

    miss-islington and encukou committed Jan 9, 2020
    GH-17896)
    
    \+ this also adds a stronger warning against sharing objects between (sub-)interpreters.
    
    https://bugs.python.org/issue39161
    (cherry picked from commit 6c5d661)
    
    Co-authored-by: Petr Viktorin <encukou@gmail.com>
  5. closes bpo-39262: Use specific out-of-memory message in _sharedexcept…

    miss-islington and alexhenrie committed Jan 9, 2020
    …ion_bind. (GH-17908)
    
    (cherry picked from commit 5cae042)
    
    Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
Commits on Jan 8, 2020
  1. bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903)

    miss-islington and corona10 committed Jan 8, 2020
    (cherry picked from commit 2e6a8ef)
    
    Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Commits on Jan 7, 2020
  1. bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (

    miss-islington and corona10 committed Jan 7, 2020
    GH-17780)
    
    Correctly parenthesize filter-based statements that contain lambda
    expressions in lib2to3.
    (cherry picked from commit b821173)
    
    Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
  2. bpo-39198: Ensure logging global lock is released on exception in isE…

    miss-islington authored and vsajip committed Jan 7, 2020
    …nabledFor (GH-17689) (GH-17897)
    
    (cherry picked from commit 950c679)
  3. [3.8] bpo-39191: Fix RuntimeWarning in asyncio test (GH-17863) (#17894)

    asvetlov committed Jan 7, 2020
    https://bugs.python.org/issue39191.
    (cherry picked from commit 10ac0cd)
    
    Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
  4. bpo-38623: Doc: Add section for site module CLI. (GH-17858)

    miss-islington and methane committed Jan 7, 2020
    (cherry picked from commit ca94677)
    
    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
  5. Doc: Change Python 2 status to EOL. (GH-17885)

    miss-islington and methane committed Jan 7, 2020
    (cherry picked from commit f4800b8)
    
    Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Commits on Jan 6, 2020
  1. bpo-39041: Fix coverage upload command for GitHub Actions (GH-17873)

    miss-islington and zooba committed Jan 6, 2020
    https://bugs.python.org/issue39041
    
    Automerge-Triggered-By: @zooba
    (cherry picked from commit b1ce22d)
    
    Co-authored-by: Steve Dower <steve.dower@python.org>
  2. bpo-29778: Fix incorrect NULL check in _PyPathConfig_InitDLLPath() (G…

    miss-islington and anthonywee committed Jan 6, 2020
    …H-17818)
    
    (cherry picked from commit 7b79dc9)
    
    Co-authored-by: Anthony Wee <awee@box.com>
  3. bpo-39041: Add GitHub Actions support (GH-17594)

    miss-islington and zooba committed Jan 6, 2020
    (cherry picked from commit a76ba36)
    
    Co-authored-by: Steve Dower <steve.dower@python.org>
  4. bpo-39209: Manage correctly multi-line tokens in interactive mode (GH…

    miss-islington and pablogsal committed Jan 6, 2020
    …-17860)
    
    (cherry picked from commit 5ec91f7)
    
    Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
  5. bpo-38907: Suppress any exception when attempting to set V6ONLY. (GH-…

    miss-islington and jaraco committed Jan 6, 2020
    …17864) (GH-17865)
    
    Fixes error attempting to bind to IPv4 address.
    (cherry picked from commit 7cdc31a)
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
  6. bpo-38907: In http.server script, restore binding to IPv4 on Windows. (

    miss-islington and jaraco committed Jan 6, 2020
    …GH-17851) (#17854)
    
    (cherry picked from commit ee94bdb)
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
    
    Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
  7. Minor formatting improvements and fixes to idle.rst (GH-17165)

    miss-islington and taleinat committed Jan 6, 2020
    (cherry picked from commit d6c08db)
    
    Co-authored-by: Tal Einat <taleinat+github@gmail.com>
Commits on Jan 5, 2020
  1. bpo-39130: Dict reversed was added in v3.8 so should say in the doc a…

    miss-islington and khalidmammadov committed Jan 5, 2020
    …s well (GH-17694)
    
    To be consistent with document layout, it should say when the feature was added.
    Although it's mentioned few other places in the doc but it's not explicitly say that at that place.
    
    https://bugs.python.org/issue39130
    (cherry picked from commit 94d9cfc)
    
    Co-authored-by: Khalid Mammadov <khalidmammadov9@gmail.com>
Older
You can’t perform that action at this time.