Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-3530: Use fix_missing_locations when node transformer adds nodes #17172

Merged
merged 6 commits into from Jan 12, 2020
Merged

bpo-3530: Use fix_missing_locations when node transformer adds nodes #17172

merged 6 commits into from Jan 12, 2020

Conversation

@isidentical
Copy link
Contributor

isidentical commented Nov 15, 2019 •
edited by miss-islington

Remove misleading (inadequate) suggestion from example.

https://bugs.python.org/issue3530

Automerge-Triggered-By: @pablogsal
@terryjreedy terryjreedy changed the title bpo-3530: advice fix_missing_locations usage on new node introduction bpo-3530: use fix_missing_locations when adding nodes Nov 17, 2019
@terryjreedy terryjreedy requested review from benjaminp and brettcannon Nov 17, 2019
@terryjreedy terryjreedy changed the title bpo-3530: use fix_missing_locations when adding nodes bpo-3530: Use fix_missing_locations when node transformer adds nodes Nov 17, 2019
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Nov 17, 2019

@isidentical Please add news item with blurb or blurb-it(sp?). Suggestion:
In ast doc, fix misleading NodeTransformer example and add fix_missing_locations advice.
@isidentical
bpo-3530: advice fix_missing_locations usage on new node introduction…
Loading status checks…
7134861 
… with NodeTransformer
@isidentical isidentical force-pushed the isidentical:bpo-3530 branch from fb6cb47 to 7134861 Nov 17, 2019
@csabella csabella requested a review from pablogsal Jan 12, 2020
@pablogsal pablogsal self-assigned this Jan 12, 2020
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Doc/library/ast.rst Outdated Show resolved Hide resolved
@isidentical
fix some markup and typos
Loading status checks…
0dca9b3
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated Show resolved Hide resolved
@isidentical @pablogsal
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b827c8 
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Doc/library/ast.rst Show resolved Hide resolved
isidentical added 2 commits Jan 12, 2020
@isidentical
add an example
2fd17e6
@isidentical
Merge branch 'bpo-3530' of github.com:isidentical/cpython into bpo-3530
Loading status checks…
2d7adb0
@pablogsal
pablogsal approved these changes Jan 12, 2020
View changes
Copy link
Member

pablogsal left a comment

LGTM! Great work! 🎉
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated Show resolved Hide resolved
@isidentical @pablogsal
Update Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8z…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f412471 
…FUMc.rst

Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal merged commit 6680f4a into python:master Jan 12, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200112.32 succeeded
Details
bedevere/issue-number Issue number 3530 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@isidentical @miss-islington
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
e1b1801 
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

GH-17972 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@isidentical @miss-islington
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
ec54571 
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

GH-17973 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 12, 2020
@miss-islington @isidentical
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e222b4c 
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 12, 2020
@miss-islington @isidentical
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ef0af30 
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@brettcannon brettcannon

@benjaminp benjaminp

Assignees

@pablogsal pablogsal

Labels
CLA signed type-documentation
Projects
None yet
Milestone
No milestone
7 participants
@isidentical @terryjreedy @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni @csabella
You can’t perform that action at this time.