Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "bpo-" in Misc/NEWS #1

Merged
merged 3 commits into from Feb 10, 2017
Merged

Support "bpo-" in Misc/NEWS #1

merged 3 commits into from Feb 10, 2017

Conversation

@brettcannon
Copy link
Member

brettcannon commented Feb 10, 2017

No description provided.

@brettcannon
Support "bpo-" in Misc/NEWS
Loading status checks…
1900740
@Carreau
Carreau reviewed Feb 10, 2017
View changes
Doc/tools/extensions/pyspecific.py Outdated
@@ -253,7 +253,7 @@ def run(self):
text = 'The NEWS file is not available.'
node = nodes.strong(text, text)
return [node]
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__',

This comment has been minimized.

Sign in to view
Copy link
@Carreau

Carreau Feb 10, 2017

Contributor

\b ? I think you overwrote the \1 :-)

This comment has been minimized.

Sign in to view
Copy link
@brettcannon

brettcannon Feb 10, 2017

Author Member

That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.

This comment has been minimized.

Sign in to view
Copy link
@Carreau

Carreau Feb 10, 2017

Contributor

Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.

This comment has been minimized.

Sign in to view
Copy link
@brettcannon

brettcannon Feb 10, 2017

Author Member

Ah, you're right. Now fixed.
@brettcannon
Fix up the match and substitution regexes
Loading status checks…
5401164 
Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.
@Carreau
Carreau approved these changes Feb 10, 2017
View changes
@zware
zware reviewed Feb 10, 2017
View changes
Doc/tools/extensions/pyspecific.py Outdated
@@ -34,7 +34,7 @@


ISSUE_URI = 'https://bugs.python.org/issue%s'
SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s'
SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s'

This comment has been minimized.

Sign in to view
Copy link
@zware

zware Feb 10, 2017

Member

Shouldn't it be master rather than 3.6 on this branch?

This comment has been minimized.

Sign in to view
Copy link
@Mariatta

Mariatta Feb 10, 2017

Member

My patch for another issue will address this, I think 🤔

http://bugs.python.org/file45904/issue28941.patch

This comment has been minimized.

Sign in to view
Copy link
@brettcannon

brettcannon Feb 10, 2017

Author Member

I went ahead and updated here since I'm already changing it.

This comment has been minimized.

Sign in to view
Copy link
@Mariatta

Mariatta Feb 10, 2017

Member

ok :)
@zware
zware reviewed Feb 10, 2017
View changes
Doc/tools/extensions/pyspecific.py Outdated
@@ -253,7 +253,7 @@ def run(self):
text = 'The NEWS file is not available.'
node = nodes.strong(text, text)
return [node]
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__',

This comment has been minimized.

Sign in to view
Copy link
@zware

zware Feb 10, 2017

Member

I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/

This comment has been minimized.

Sign in to view
Copy link
@brettcannon

brettcannon Feb 10, 2017

Author Member

Done.
@brettcannon
Address reviewer comments
Loading status checks…
02a87ce
@zware
zware approved these changes Feb 10, 2017
View changes
@zware zware merged commit 79ab8be into master Feb 10, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@brettcannon brettcannon deleted the bpo-news-support branch Feb 10, 2017
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
@brettcannon @Mariatta
Support "bpo-" in Misc/NEWS (#1)
98cb83e 
(cherry picked from commit 79ab8be)
@Mariatta Mariatta mentioned this pull request Feb 12, 2017
Merged
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
@brettcannon @Mariatta
Support "bpo-" in Misc/NEWS (#1)
73e2903 
Change the url to 3.5

(cherry picked from commit 79ab8be)

# Conflicts:
#	Doc/tools/extensions/pyspecific.py
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
@Mariatta
Support "bpo-" in Misc/NEWS (#1)
63b8f25 
Change the url to 2.7

(cherry picked from commit 79ab8be)
Mariatta added a commit that referenced this pull request Feb 12, 2017
@Mariatta
[backport to 2.7] Change documentation's `Show Source` link to GitHub (…
52b8c55 
…#44)

* Support "bpo-" in Misc/NEWS (#1)
Change the url to 2.7

(cherry picked from commit 79ab8be)

* pyspecific.py: remove space after` bpo-`
Mariatta added a commit that referenced this pull request Feb 13, 2017
@Mariatta
Support "bpo-" in Misc/NEWS (#1) (#43)
af456b2 
Change the url to 3.5

(cherry picked from commit 79ab8be)

Contributed by Brett Cannon
tiran added a commit that referenced this pull request Aug 28, 2017
@pylessard @tiran
bpo-30987 - Support for ISO-TP protocol in SocketCAN (#2956)
Loading status checks…
a30f6d4 
* Added support for CAN_ISOTP protocol

* Added unit tests for CAN ISOTP

* Updated documentation for ISO-TP protocol

* Removed trailing whitespace in documentation

* Added blurb NEWS.d file

* updated Misc/ACKS

* Fixed broken unit test that was using isotp const outside of skippable section

* Removed dependecy over third party project

* Added implementation for getsockname + unit tests

* Missing newline at end of ACKS file

* Accidentally inserted a type in ACKS file

* Followed tiran changes review #1 recommendations

* Added spaces after comma
GadgetSteve added a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@pylessard @GadgetSteve
bpo-30987 - Support for ISO-TP protocol in SocketCAN (python#2956)
04f20ba 
* Added support for CAN_ISOTP protocol

* Added unit tests for CAN ISOTP

* Updated documentation for ISO-TP protocol

* Removed trailing whitespace in documentation

* Added blurb NEWS.d file

* updated Misc/ACKS

* Fixed broken unit test that was using isotp const outside of skippable section

* Removed dependecy over third party project

* Added implementation for getsockname + unit tests

* Missing newline at end of ACKS file

* Accidentally inserted a type in ACKS file

* Followed tiran changes review python#1 recommendations

* Added spaces after comma
daxlab added a commit to daxlab/cpython that referenced this pull request Oct 1, 2017
@pylessard @daxlab
bpo-30987 - Support for ISO-TP protocol in SocketCAN (python#2956)
caca9f5 
* Added support for CAN_ISOTP protocol

* Added unit tests for CAN ISOTP

* Updated documentation for ISO-TP protocol

* Removed trailing whitespace in documentation

* Added blurb NEWS.d file

* updated Misc/ACKS

* Fixed broken unit test that was using isotp const outside of skippable section

* Removed dependecy over third party project

* Added implementation for getsockname + unit tests

* Missing newline at end of ACKS file

* Accidentally inserted a type in ACKS file

* Followed tiran changes review python#1 recommendations

* Added spaces after comma
@csabella csabella mentioned this pull request Dec 22, 2017
Merged
@bapt bapt mentioned this pull request Jan 18, 2018
Closed
native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018
@roseman
Merge pull request python#1 from native-api/roseman_1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9a5b0e8 
python#7287 (comment)
@Clucier17
Clucier17 reviewed Jul 28, 2018
View changes
@aixtools aixtools mentioned this pull request Oct 26, 2018
Closed
@brianquinlan brianquinlan mentioned this pull request May 8, 2019
Merged
@tim-one tim-one mentioned this pull request May 29, 2019
Merged
@ElizabethU ElizabethU mentioned this pull request Jul 20, 2019
Merged
@btharper btharper mentioned this pull request Oct 6, 2019
Merged
attilajeges added a commit to attilajeges/cpython that referenced this pull request Dec 14, 2019
@attilajeges
Issue python#1: skip chflags UF_IMMUTABLE tests if EOPNOTSUPP is raised.
c9de88b 
This is necessary for ZFS systems, which don't support UF_IMMUTABLE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

@Clucier17 Clucier17

@Carreau Carreau

@zware zware

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@brettcannon @Carreau @Mariatta @zware @Clucier17 @the-knights-who-say-ni
You can’t perform that action at this time.