Update configparser.py #16772
Update configparser.py #16772
Conversation
RawConfigParser.set() fix to allow non-truthy values (False, None, 0 etc) to pass through to Interpolation.before_set()
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
It is not trivial, as it changes the behavior. So this change needs to be documented and tested. Note also that it breaks existing tests, so it may be not a desirable change. |
|
Thanks for this PR, it looks like a nice fix! Indeed, this is non-trivial as it would change behavior, i.e. break backwards compatibility. We'd need to decide that fixing this is worth the break. Please go to bugs.python.org, create an account if you don't have one, and create an issue about this. That would be the best place to discuss this. Feel free to add me to the "nosy" list for the issue (my user is the same there) so that I may participate. |
|
@HStry, please address the code reviews and open a bug tracker issue for this. If a ticket isn't opened, we'll have to close your pull request. Thank you! |
|
Sorry for the radio silence, It's been quite an eventful few months and
this completely fell through the cracks.
Serhiy Storchaka, it seems you're absolutely right. I assumed too soon it
was an easy fix and didn't test it thoroughly enough, and had (and still
have) no idea how to work with those auto-tests. I'll look into that to
prevent similar failed checks next time.
Tal Einat, thank you for the kind words, I'll go and open an issue on this,
and add you to the nosy list.
Cheryl Sabella - Thanks for the reminder, I probably wouldn't have gotten
back to this otherwise.
With kind regards,
Hans Strijker
…On Sat, Jan 11, 2020 at 1:18 AM Cheryl Sabella ***@***.***> wrote:
@HStry <https://github.com/HStry>, please address the code reviews and
open a bug tracker issue for this. If a ticket isn't opened, we'll have to
close your pull request. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16772?email_source=notifications&email_token=AK2BJGA6MDC545MDYO6S2UTQ5EF6VA5CNFSM4JAN64YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVS45A#issuecomment-573255284>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK2BJGFEZL77LHA6XDT26JTQ5EF6VANCNFSM4JAN64YA>
.
|
|
@HStry, thanks Hans. If you have any questions about the process, just let us know. |
|
I'm going to close this pull request due to inactivity. @HStry, if you're interested in pursuing this, please open an issue on the bug tracker. Once others have commented and agreed that the change should be made, a new PR could be created. Thanks! |
RawConfigParser.set does not pass non-truthy values through to Interpolation.before_set
Apologies for missing bpo-NNNN, fix seems trivial, and first pull request, don't know my way around to create a bpo number yet.
RawConfigParser.set() fix to allow non-truthy values (False, None, 0 etc) to pass through to Interpolation.before_set(). Currently default value being None leading to unexpected results. Using the established _UNSET constant to determine a value being passed to set.