Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venv: Suppress warning message when bash hashing is disabled. #17966

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Jan 12, 2020

When using python's built-in venv activaton script warnings are printed when hashing is disabled in bash or zsh, like;

bash: hash: hashing disabled

This output is not really useful to the end-user and has been disabled in virtualenv for long.

This commit is based on:
pypa/virtualenv@28e85bc

It would be nice to backport this to all relevant versions if possible.

Edit: this issue seems very small, so I did not bother with an issue or a NEWS entry, let me know if you think this might still be required.

When using python's built-in venv activaton script
warnings are printed when hashing is disabled in
bash or zsh, like;

`bash: hash: hashing disabled`

This output is not really useful to the end-user and has
been disabled in `virtualenv` for long.

This commit is based on:
pypa/virtualenv@28e85bc
@d-goldin d-goldin requested a review from vsajip as a code owner Jan 12, 2020
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 12, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@d-goldin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@vsajip
vsajip approved these changes Jan 14, 2020
@vsajip vsajip merged commit 4b0d91a into python:master Jan 14, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200112.21 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.