Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28334: netrc() now uses expanduser() to find .netrc file #4537

Merged
merged 3 commits into from Nov 25, 2017
Merged

bpo-28334: netrc() now uses expanduser() to find .netrc file #4537

merged 3 commits into from Nov 25, 2017

Conversation

berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Nov 24, 2017 •
edited

Previously, netrc.netrc() was raised an exception if
$HOME is not set.

Authored-By: Dimitri Merejkowsky <dimitri.merejkowsky@tanker.io>

https://bugs.python.org/issue28334

@dmerejkowsky @berkerpeksag
bpo-28334: fix netrc not working when $HOME is not set
ce9d8e6 
Also add more tests to check that proper exceptions are raised
@berkerpeksag berkerpeksag mentioned this pull request Nov 24, 2017
Closed
@berkerpeksag berkerpeksag reopened this Nov 24, 2017
@berkerpeksag berkerpeksag changed the title [DO NOT MERGE] bpo-28334: fix netrc not working when $HOME is not set bpo-28334: fix netrc not working when $HOME is not set Nov 25, 2017
@berkerpeksag berkerpeksag changed the title bpo-28334: fix netrc not working when $HOME is not set bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc Nov 25, 2017
@berkerpeksag berkerpeksag changed the title bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc bpo-28334: netrc() now uses expanduser() to find .netrc file Nov 25, 2017
@berkerpeksag berkerpeksag merged commit 8d9bb11 into python:master Nov 25, 2017
3 checks passed
@berkerpeksag berkerpeksag deleted the 28334-netrc branch Nov 25, 2017
@sloria sloria mentioned this pull request Jan 12, 2018
Closed
sloria added a commit to sloria/tinynetrc that referenced this issue Jan 12, 2018
@sloria
Use expanduser() to find netrc file
d923e8d 
Avoids an exception when $HOME is not set.
This behavior matches the behavior in Python 3.7
See python/cpython#4537

close #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@berkerpeksag @the-knights-who-say-ni @bedevere-bot @dmerejkowsky