Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39235: Check end_lineno and end_col_offset of AST nodes. #17926
+104
−102
Conversation
serhiy-storchaka
changed the title
This comment has been minimized.
This comment has been minimized.
|
Should this be backported to 3.8? Which should be merged first, this one or GH-17925? Should I still add the test that @pablogsal suggested in GH-17925? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
OK. I suppose you have to recalculate now that GH-17925 has landed? |
This comment has been minimized.
This comment has been minimized.
|
Yes, see bab2c12. |
serhiy-storchaka
merged commit 850a885
into
python:master
8 checks passed
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
serhiy-storchaka commentedJan 9, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39235