Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39274: Ensure `Fraction.__bool__` returns a bool #18017

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39274: Ensure `Fraction.__bool__` returns a bool #18017

wants to merge 1 commit into from
+22 −1

Conversation

@seberg
Copy link
Contributor

seberg commented Jan 15, 2020 •
edited by bedevere-bot

Some numerator types used (specifically NumPy) decides to not
return a python boolean for the != operation. Using the equivalent
call to bool() guarantees a bool return also for such types.

Closes bpo-39274

https://bugs.python.org/issue39274

https://bugs.python.org/issue39274
@seberg
BUG: Ensure `Fraction.__bool__` returns a bool
Loading status checks…
ad8031b 
Some numerator types used (specifically NumPy) decides to not
return a python boolean for the `!=` operation. Using the equivalent
call to `bool()` guarantees a bool return also for such types.

Closes bpo-39274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@seberg @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.