Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38519: Internal include files missing on Windows #16921

Merged
merged 2 commits into from Oct 28, 2019
Merged

bpo-38519: Internal include files missing on Windows #16921

merged 2 commits into from Oct 28, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 25, 2019 •
edited by bedevere-bot

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner Oct 25, 2019
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Oct 25, 2019

@zooba Do you think we need a news entry for this?

eamanu
eamanu approved these changes Oct 25, 2019
View changes
Copy link
Contributor

@eamanu eamanu left a comment

LGTM. IMO we need NEWs

@zooba
Copy link
Member

zooba commented Oct 25, 2019

Agreed. A NEWS entry reading Restores the internal C headers that were missing from the nuget.org and Microsoft Store packages would be fine.

zooba
zooba approved these changes Oct 25, 2019
View changes
Copy link
Member

@zooba zooba left a comment

Approved with NEWS entry

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Oct 28, 2019

I have added a news entry.

@zooba zooba merged commit edb172a into python:master Oct 28, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 28, 2019

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 28, 2019

GH-16966 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 28, 2019
@miss-islington @ZackerySpytz
bpo-38519: Internal include files missing on Windows (GH-16921)
07eee64 
(cherry picked from commit edb172a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ZackerySpytz
bpo-38519: Internal include files missing on Windows (pythonGH-16921)
9aef579
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ZackerySpytz @shihai1991
bpo-38519: Internal include files missing on Windows (pythonGH-16921)
4705c6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

@eamanu eamanu

Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ZackerySpytz @zooba @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni