Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38820: OpenSSL 3.0.0 compatibility. #17190

Merged
merged 1 commit into from Dec 7, 2019

Conversation

@tiran
Copy link
Member

tiran commented Nov 16, 2019

test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38820

Automerge-Triggered-By: @tiran

Copy link
Contributor

benjaminp left a comment

That's certainly a weird behavior.

Modules/_ssl.c Show resolved Hide resolved
test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the tiran:bpo-38820-openssl300 branch from 0253424 to 560ecec Dec 7, 2019
@tiran tiran added the 🤖 automerge label Dec 7, 2019
@miss-islington miss-islington merged commit 2b7de66 into python:master Dec 7, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191207.10 succeeded
Details
bedevere/issue-number Issue number 38820 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Dec 7, 2019

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 7, 2019
test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38820
(cherry picked from commit 2b7de66)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 7, 2019

GH-17499 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 7, 2019

GH-17500 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 7, 2019
test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38820
(cherry picked from commit 2b7de66)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this pull request Dec 7, 2019
test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue38820
(cherry picked from commit 2b7de66)


Co-authored-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue38820



Automerge-Triggered-By: @tiran
miss-islington added a commit that referenced this pull request Dec 7, 2019
test_openssl_version now accepts version 3.0.0.

getpeercert() no longer returns IPv6 addresses with a trailing new line.

Signed-off-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue38820
(cherry picked from commit 2b7de66)


Co-authored-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue38820



Automerge-Triggered-By: @tiran
sthagen added a commit to sthagen/cpython that referenced this pull request Dec 7, 2019
bpo-38820: OpenSSL 3.0.0 compatibility. (pythonGH-17190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.